Bug 305316 - [Sync View][Apply Patch] Patch Options UI polishing
Summary: [Sync View][Apply Patch] Patch Options UI polishing
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Team (show other bugs)
Version: 3.6   Edit
Hardware: PC Windows XP
: P3 minor (vote)
Target Milestone: 3.6 M7   Edit
Assignee: Pawel Pogorzelski CLA
QA Contact:
URL:
Whiteboard:
Keywords: polish
Depends on:
Blocks: 300345
  Show dependency tree
 
Reported: 2010-03-10 08:41 EST by Tomasz Zarna CLA
Modified: 2010-03-11 08:23 EST (History)
0 users

See Also:


Attachments
Patch_v01 (3.67 KB, patch)
2010-03-11 08:21 EST, Pawel Pogorzelski CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tomasz Zarna CLA 2010-03-10 08:41:33 EST
HEAD

The UI for Patch Option in Sync view has few minor glitches:
* "Generate .rej File" should be replaced with "Generate a .rej File for Unmerged Hunks". Or should we say "Conflicting" while in the Sync view?
* Guess button misses mnemonic
* Guess button's width need to be adjusted, take a look at org.eclipse.compare.internal.patch.PreviewPatchPage2.createFuzzFactorChooser(Composite) to see how it's done in the wizard
* In the "Go to Line" dialog, which is very similar to the "Fuzz Factor" dialog, when there no value entered in the text field, the OK button is disabled but there is *no* message saying "Not a number". Is that intentional?
* "Enter Fuzz Factor" in the dialog should end with ":"
* do action in the drop down have mnemonics?
Comment 1 Pawel Pogorzelski CLA 2010-03-11 07:58:24 EST
(In reply to comment #0)
> * In the "Go to Line" dialog, which is very similar to the "Fuzz Factor"
> dialog, when there no value entered in the text field, the OK button is
> disabled but there is *no* message saying "Not a number". Is that intentional?

It is. This is the way "New Java Class", "New File" and many other wizards work.
Comment 2 Pawel Pogorzelski CLA 2010-03-11 08:21:55 EST
Created attachment 161737 [details]
Patch_v01
Comment 3 Pawel Pogorzelski CLA 2010-03-11 08:23:54 EST
Patch_v01 in HEAD, marking as FIXED.