Bug 305156 - NPE when trying to use Search dialog
Summary: NPE when trying to use Search dialog
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.6   Edit
Hardware: All Windows XP
: P3 critical (vote)
Target Milestone: 3.6 M6   Edit
Assignee: Boris Bokowski CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 305190 305323 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-03-09 09:26 EST by Markus Keller CLA
Modified: 2010-03-11 03:40 EST (History)
6 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2010-03-09 09:26:55 EST
I20100309-0100, was OK in I20100302-0800

- new workspace
- Ctrl+H
- type 'a'
- click 'Search' button
=> Search view opens, but dialog is not closed. Only second or third click closes the dialog.

Problem is repeatable when Search view is closed.


Reason is an NPE in PageBookView.createPage(..) due to new code from bug 201301:

!ENTRY org.eclipse.ui 4 0 2010-03-09 15:24:09.803
!MESSAGE Unhandled event loop exception
!STACK 0
java.lang.NullPointerException
	at org.eclipse.ui.part.PageBookView.createPage(PageBookView.java:415)
	at org.eclipse.ui.part.PageBookView.partActivated(PageBookView.java:757)
	at org.eclipse.search2.internal.ui.SearchView.partActivated(SearchView.java:319)
	at org.eclipse.search2.internal.ui.SearchView.internalShowSearchPage(SearchView.java:403)
	at org.eclipse.search2.internal.ui.SearchView.showSearchResult(SearchView.java:374)
	at org.eclipse.search2.internal.ui.SearchViewManager.showNewSearchQuery(SearchViewManager.java:70)
	at org.eclipse.search2.internal.ui.SearchViewManager$1.queryAdded(SearchViewManager.java:47)
	at org.eclipse.search2.internal.ui.QueryManager.fireAdded(QueryManager.java:93)
	at org.eclipse.search2.internal.ui.QueryManager.addQuery(QueryManager.java:70)
	at org.eclipse.search2.internal.ui.InternalSearchUI.addQuery(InternalSearchUI.java:309)
	at org.eclipse.search2.internal.ui.InternalSearchUI.runSearchInBackground(InternalSearchUI.java:167)
	at org.eclipse.search.ui.NewSearchUI.runQueryInBackground(NewSearchUI.java:132)
	at org.eclipse.search.ui.NewSearchUI.runQueryInBackground(NewSearchUI.java:105)
	at org.eclipse.search.internal.ui.text.TextSearchPage.performAction(TextSearchPage.java:243)
	at org.eclipse.search.internal.ui.SearchDialog.performAction(SearchDialog.java:459)
	at org.eclipse.search.internal.ui.util.ExtendedDialogWindow.buttonPressed(ExtendedDialogWindow.java:164)
	at org.eclipse.jface.dialogs.Dialog$2.widgetSelected(Dialog.java:624)
	at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:228)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:87)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1050)
	at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4037)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3628)
	at org.eclipse.jface.window.Window.runEventLoop(Window.java:825)
	at org.eclipse.jface.window.Window.open(Window.java:801)
	at org.eclipse.search.internal.ui.OpenSearchDialogAction.run(OpenSearchDialogAction.java:54)
	at org.eclipse.search.internal.ui.OpenSearchDialogAction.run(OpenSearchDialogAction.java:45)
	at org.eclipse.ui.internal.handlers.ActionDelegateHandlerProxy.execute(ActionDelegateHandlerProxy.java:289)
	at org.eclipse.core.commands.Command.executeWithChecks(Command.java:476)
	at org.eclipse.core.commands.ParameterizedCommand.executeWithChecks(ParameterizedCommand.java:508)
	at org.eclipse.ui.internal.handlers.HandlerService.executeCommand(HandlerService.java:169)
	at org.eclipse.ui.internal.keys.WorkbenchKeyboard.executeCommand(WorkbenchKeyboard.java:468)
	at org.eclipse.ui.internal.keys.WorkbenchKeyboard.press(WorkbenchKeyboard.java:786)
	at org.eclipse.ui.internal.keys.WorkbenchKeyboard.processKeyEvent(WorkbenchKeyboard.java:885)
	at org.eclipse.ui.internal.keys.WorkbenchKeyboard.filterKeySequenceBindings(WorkbenchKeyboard.java:567)
	at org.eclipse.ui.internal.keys.WorkbenchKeyboard.access$3(WorkbenchKeyboard.java:508)
	at org.eclipse.ui.internal.keys.WorkbenchKeyboard$KeyDownFilter.handleEvent(WorkbenchKeyboard.java:123)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:87)
	at org.eclipse.swt.widgets.Display.filterEvent(Display.java:1250)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1049)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1074)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1059)
	at org.eclipse.swt.widgets.Widget.sendKeyEvent(Widget.java:1100)
	at org.eclipse.swt.widgets.Widget.sendKeyEvent(Widget.java:1096)
	at org.eclipse.swt.widgets.Widget.wmChar(Widget.java:1505)
	at org.eclipse.swt.widgets.Control.WM_CHAR(Control.java:4247)
	at org.eclipse.swt.widgets.Tree.WM_CHAR(Tree.java:5844)
	at org.eclipse.swt.widgets.Control.windowProc(Control.java:4139)
	at org.eclipse.swt.widgets.Tree.windowProc(Tree.java:5840)
	at org.eclipse.swt.widgets.Display.windowProc(Display.java:4843)
	at org.eclipse.swt.internal.win32.OS.DispatchMessageW(Native Method)
	at org.eclipse.swt.internal.win32.OS.DispatchMessage(OS.java:2456)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3626)
	at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2416)
	at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2380)
	at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2229)
	at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:504)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:497)
	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
	at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:115)
	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:369)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:597)
	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:619)
	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:574)
	at org.eclipse.equinox.launcher.Main.run(Main.java:1406)
	at org.eclipse.equinox.launcher.Main.main(Main.java:1382)
Comment 1 Remy Suen CLA 2010-03-09 09:41:26 EST
Reproduced on my end. ;_;
Comment 2 Boris Bokowski CLA 2010-03-09 10:00:38 EST
Fixed in HEAD. Thanks Markus!
Comment 3 Darin Wright CLA 2010-03-09 12:02:48 EST
*** Bug 305190 has been marked as a duplicate of this bug. ***
Comment 4 Remy Suen CLA 2010-03-10 09:09:23 EST
*** Bug 305323 has been marked as a duplicate of this bug. ***
Comment 5 Markus Keller CLA 2010-03-11 03:40:36 EST
Verified in I20100310-1800.