Bug 304009 - Consider adopting synchronize with patches in Task Editor
Summary: Consider adopting synchronize with patches in Task Editor
Status: CLOSED MOVED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday, helpwanted
: 340827 (view as bug list)
Depends on: 309803 325348
Blocks:
  Show dependency tree
 
Reported: 2010-02-26 05:14 EST by Tomasz Zarna CLA
Modified: 2011-04-03 19:58 EDT (History)
2 users (show)

See Also:

Attachments
mylyn/context/zip (3.01 KB, application/octet-stream)
2010-02-27 16:26 EST, Steffen Pingel CLA 		no flags Details
mylyn/context/zip (6.19 KB, application/octet-stream)
2010-07-19 08:52 EDT, Tomasz Zarna CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomasz Zarna CLA 2010-02-26 05:14:02 EST 
In 3.6 we are going to ship a new feature that would allow to apply patches using the Sync View. At this moment, we're working hard to make this new feature as functional as the old Apply Patch wizard. However, in the future we would like it to be even more powerful (see bug 198149 and bug 303887). 

I don't need to say I'm a big fan of Mylyn and I would be happy to see this adopted in your Tasks editor. The question: what would need to happen to make this come true? I'm not very familiar with Mylyn internals, so I don't if there is anything I could help you with? Is there anything we would need to change in Team/Compare to make this work?
Comment 1 Steffen Pingel CLA 2010-02-27 16:26:05 EST 
Thanks for the heads up. That sounds very cool and it would be great to have Mylyn integration for the patch support in the synchronize view. 

The current integration in the org.eclipse.mylyn.team.ui plug-in is fairly simple. Mylyn invokes org.eclipse.compare.patch.ApplyPatchOperation and provides an implementation of IStorage that reads data from task attachments (see context) when Apply Patch is invoked from the popup menu of a task attachment.

Do you have anything particular in mind to integrate with the new functionality? Adding additional contributions to the popup menu of task attachments is straight forward. As long as there is API in Team/Compare that can read patches from an input stream or something equivalent we should be able to make this work.
Comment 2 Steffen Pingel CLA 2010-02-27 16:26:09 EST 
Created attachment 160409 [details]
mylyn/context/zip
Comment 3 Steffen Pingel CLA 2010-07-09 00:08:42 EDT 
Tomasz, could you attach a context that points to the right place in the team API for accessing the new synchronize with patch functionality?
Comment 4 Steffen Pingel CLA 2010-07-15 18:48:10 EDT 
Marking helpwanted to indicate that we would be happy to support a contribution.
Comment 5 Tomasz Zarna CLA 2010-07-19 08:52:59 EDT 
Created attachment 174610 [details]
mylyn/context/zip

Well, the API is not yet ready, see the blocking bug. I'm attaching a context that points to couple of classes that should be visited in the first place when we start to form such API.
Comment 6 Steffen Pingel CLA 2011-04-03 19:58:29 EDT 
*** Bug 340827 has been marked as a duplicate of this bug. ***
Comment 7 Eclipse Webmaster CLA 2022-11-15 11:45:08 EST 
Mylyn has been restructured, and our issue tracking has moved to GitHub [1].

We are closing ~14K Bugzilla issues to give the new team a fresh start. If you feel that this issue is still relevant, please create a new one on GitHub.

[1] https://github.com/orgs/eclipse-mylyn