Bug 303993 - [Patch] Preview for Patch Creation
Summary: [Patch] Preview for Patch Creation
Status: ASSIGNED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: CVS (show other bugs)
Version: 3.4   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: platform-cvs-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-26 01:06 EST by Brock Janiczak CLA
Modified: 2019-09-06 16:09 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Brock Janiczak CLA 2010-02-26 01:06:36 EST
Build Identifier: I20090430-2300

There is currently no way to preview the contents of a patch from the CVS patch creation wizard.  The current procedure would be to create the patch then open it to verify that all changes are present and no other changes snuck in.

Would it be possible to make the patch creation wizard like the commit dialog where you can select a file and it will show a compare editor with the local changes?

Perhaps even having a preview on the last page that uses the synchronize view patch support that was recently added?

Reproducible: Always
Comment 1 Szymon Brandys CLA 2010-02-26 04:56:42 EST
If you need a preview, why not to do synchronization first and then in Sync View select those resources you want to include in the patch? Actually we've been trying to get rid of any preview compare dialogs in Eclipse and use Sync View to preview.
Comment 2 Brock Janiczak CLA 2010-02-28 18:04:26 EST
I never thought of doing it that way.  Should the create patch operation switch to the synchronize perspective and populate it with workspace changes for the current selection.  You could then map the commit all outgoing changes to create the patch file.  Basically it would work like the opposite of the new patch apply workflow.
Comment 3 Tomasz Zarna CLA 2010-03-01 05:54:25 EST
Both ideas sounds reasonable to me. The first one, about adding a compare editor pane to the Create Patch wizard would be more consistent with the current shape of all the wizards and dialogs we have in our UI. The fact is that we're slowing moving away from dialogs since working with editors and the sync view is more flexible - you can modify a file and don't need to close a dialog/wizard to do so. Like I said, both approaches are fine, but I think the second (comment 2) would be the way to go.
Comment 4 Eclipse Webmaster CLA 2019-09-06 16:09:43 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.