Bug 302654 - support for Bugzilla 3.6
Summary: support for Bugzilla 3.6
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: Macintosh All
: P2 enhancement (vote)
Target Milestone: 3.4   Edit
Assignee: Frank Becker CLA
QA Contact:
URL:
Whiteboard:
Keywords: plan
Depends on: 310875
Blocks:
  Show dependency tree
 
Reported: 2010-02-11 16:59 EST by Frank Becker CLA
Modified: 2010-05-23 16:59 EDT (History)
3 users (show)

See Also:


Attachments
commited patch (5.67 KB, patch)
2010-02-13 17:34 EST, Frank Becker CLA
no flags Details | Diff
mylyn/context/zip (7.29 KB, application/octet-stream)
2010-02-13 17:34 EST, Frank Becker CLA
no flags Details
commited patch (9.81 KB, patch)
2010-04-26 15:21 EDT, Frank Becker CLA
no flags Details | Diff
mylyn/context/zip (24.11 KB, application/octet-stream)
2010-04-26 15:21 EDT, Frank Becker CLA
no flags Details
patch (2.86 KB, patch)
2010-04-26 15:57 EDT, Frank Becker CLA
no flags Details | Diff
mylyn/context/zip (10.38 KB, application/octet-stream)
2010-04-26 15:57 EDT, Frank Becker CLA
no flags Details
patch (10.03 KB, patch)
2010-05-07 16:20 EDT, Frank Becker CLA
no flags Details | Diff
mylyn/context/zip (10.78 KB, application/octet-stream)
2010-05-07 16:20 EDT, Frank Becker CLA
no flags Details
corrections (5.64 KB, patch)
2010-05-13 14:43 EDT, Frank Becker CLA
no flags Details | Diff
mylyn/context/zip (11.45 KB, application/octet-stream)
2010-05-13 14:43 EDT, Frank Becker CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Frank Becker CLA 2010-02-11 16:59:12 EST
Bugzilla 3.5.3 has the following change

* comments for attachments changed 
   from 
       Created an attachment (id=????)
   to
       Created attachment ????
   
   This breaks SaxMultiBugReportContentHandler.parseAttachment so Creator and created are no longer filled.
Comment 1 Frank Becker CLA 2010-02-11 17:16:54 EST
We can use the child tags from <attachment> for the created (Tag <date) and Creator (Tag <attacher>) information.

 So there is no need for grep the comment text.
 
 We then cane use tag <delta_ts> for last mod date.
 
 This works with older Bugzilla versions to.
 
 Thoughts?
Comment 2 Steffen Pingel CLA 2010-02-11 22:20:32 EST
When is 3.6 scheduled to be released?
Comment 3 Robert Elves CLA 2010-02-11 23:10:12 EST
(In reply to comment #1)
> We can use the child tags from <attachment> for the created (Tag <date) and
> Creator (Tag <attacher>) information.
> 
> So there is no need for grep the comment text.
> 
> We then cane use tag <delta_ts> for last mod date.
> 
> This works with older Bugzilla versions to.
> 
> Thoughts?
Sound right Frank.

(In reply to comment #2)
> When is 3.6 scheduled to be released?
July 13
Comment 4 Steffen Pingel CLA 2010-02-12 00:30:23 EST
Should this get scheduled for 3.4? Seems important that we would have support for Bugzilla 3.6 as part of Helios.
Comment 5 Frank Becker CLA 2010-02-13 17:34:53 EST
Created attachment 159063 [details]
commited patch

CreationDate and Autor for Attachments can now parsed in new and old format.
Comment 6 Frank Becker CLA 2010-02-13 17:34:57 EST
Created attachment 159064 [details]
mylyn/context/zip
Comment 7 Steffen Pingel CLA 2010-04-23 22:15:17 EDT
Frank, did you manage to setup a test repository for 3.6?
Comment 8 Frank Becker CLA 2010-04-24 14:53:43 EDT
(In reply to comment #7)
> Frank, did you manage to setup a test repository for 3.6?

Yes the repository is available but I need to finis the setup (add users,..)

and

config the XMLRPC components
Comment 9 Steffen Pingel CLA 2010-04-24 15:16:43 EDT
Just copy (dump/restore) a databases from Bugzilla 3.4 and let checksetup do the rest.
Comment 10 Frank Becker CLA 2010-04-26 15:21:52 EDT
Created attachment 166121 [details]
commited patch

Now we have an bugs36 test repo at http://mylyn.eclipse.org/bugs36/

I have create the new file clean_bugs_3_6_with2bugs.sql that you can load to restore the database.

All test pass with no error.
Comment 11 Frank Becker CLA 2010-04-26 15:21:57 EDT
Created attachment 166122 [details]
mylyn/context/zip
Comment 12 Frank Becker CLA 2010-04-26 15:57:01 EDT
Created attachment 166129 [details]
patch

add test for verify that XMLRPC is installed.

This use http://mylyn.eclipse.org/bugs36noxmlrpc/ which use the same database as http://mylyn.eclipse.org/bugs36/ .
Comment 13 Frank Becker CLA 2010-04-26 15:57:04 EDT
Created attachment 166130 [details]
mylyn/context/zip
Comment 14 Steffen Pingel CLA 2010-04-29 22:09:58 EDT
Great stuff, Frank! Here are a two minor suggestions:

* Rename BugzillaXMLRPCTest to BugzillaXmlRpcTest to make it consistent with the project naming conventions.
* Consider creating fixtures for the added repositories, e.g.:

	public static BugzillaFixture BUGS_3_6_XML_RPC_DISABLED = new BugzillaFixture(BugzillaTestConstants.TEST_BUGZILLA_36_URL + "noxmlrpc", //
			"3.6", "XML-RPC disabled");
	public static BugzillaFixture BUGS_3_6_CUSTOM_WF = new BugzillaFixture(BugzillaTestConstants.TEST_BUGZILLA_36_URL + "customwf", //
			"3.6", "Custom Workflow");

We probably don't need to run all tests against the new repository, yet. The ones that invoke functionality related to XML-RPC or workflows should be sufficient.
Comment 15 Frank Becker CLA 2010-05-07 16:20:24 EDT
Created attachment 167561 [details]
patch

now we have the following new repositories
* bugs36noxmlrpc
* bugs36customWF
in place.
Comment 16 Frank Becker CLA 2010-05-07 16:20:28 EDT
Created attachment 167562 [details]
mylyn/context/zip
Comment 17 Frank Becker CLA 2010-05-13 14:43:33 EDT
Created attachment 168437 [details]
corrections

see comment#14

here are the 3.6 specific fixtures BUGS_3_6_CUSTOM_WF, BUGS_3_6_NO_XMLRPC, BUGS_3_6_CUSTOM_WF_AND_STATUS

and the following URL's
http://mylyn.eclipse.org/bugs36-custom-wf
http://mylyn.eclipse.org/bugs36-custom-wf-and-status
http://mylyn.eclipse.org/bugs36-xml-rpc-disabled
Comment 18 Frank Becker CLA 2010-05-13 14:43:37 EDT
Created attachment 168438 [details]
mylyn/context/zip
Comment 19 Steffen Pingel CLA 2010-05-18 13:47:05 EDT
What's left to do here?
Comment 20 Frank Becker CLA 2010-05-23 16:59:16 EDT
(In reply to comment #19)
> What's left to do here?

I think we are done.