Bug 302015 - [context] do not filter nodes when navigating hierarchies with Alt+click
Summary: [context] do not filter nodes when navigating hierarchies with Alt+click
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P2 enhancement (vote)
Target Milestone: 3.5   Edit
Assignee: Shawn Minto CLA
QA Contact:
URL:
Whiteboard:
Keywords: noteworthy
Depends on:
Blocks: 272089
  Show dependency tree
 
Reported: 2010-02-05 17:48 EST by Steffen Pingel CLA
Modified: 2011-02-14 13:20 EST (History)
2 users (show)

See Also:


Attachments
patch (3.92 KB, patch)
2010-02-05 17:53 EST, Shawn Minto CLA
no flags Details | Diff
updated patch (6.13 KB, patch)
2011-02-13 19:27 EST, Shawn Minto CLA
no flags Details | Diff
mylyn/context/zip (3.54 KB, application/octet-stream)
2011-02-13 19:27 EST, Shawn Minto CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Steffen Pingel CLA 2010-02-05 17:48:00 EST
As you navigate hierarchies with Alt+click nodes that were temporarily unfiltered are re-filtered whenever a node is selected. This can cause the selection and nodes to jump as the scrollbar is adjusted and can make it difficult to find the right nodes. I think it would be better if all children of nodes that are clicked stay visible until the Alt+click operation is complete.
Comment 1 Shawn Minto CLA 2010-02-05 17:53:00 EST
Created attachment 158363 [details]
patch

I like this idea since it can be disorienting when using alt+click and the tree continuously changes form and jumps around with every click.  I wonder if this should be a option or not though as it does radically change the behavior that users are used to (on by default though).

Here is a quick patch that adds this support.  There are some anomalies with refresh that we need to sort out before we commit this change though.
Comment 2 Shawn Minto CLA 2011-02-13 19:27:26 EST
Created attachment 188860 [details]
updated patch

Here is the patch that I will commit that implements this behavior.  This makes navigating with Alt+Click much easier.  The only case where we still adjust the view is after the user Alt+clicks on the tree to show all projects as leaving this open can have performance implications.
Comment 3 Shawn Minto CLA 2011-02-13 19:27:30 EST
Created attachment 188861 [details]
mylyn/context/zip
Comment 4 Shawn Minto CLA 2011-02-13 19:28:09 EST
I have committed this patch.