Bug 301422 - [Mac] [Progress] restart dialog not parented correctly when modal dialog is up
Summary: [Mac] [Progress] restart dialog not parented correctly when modal dialog is up
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.6   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 231150
  Show dependency tree
 
Reported: 2010-02-01 10:18 EST by Thomas Watson CLA
Modified: 2019-09-06 16:03 EDT (History)
6 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Watson CLA 2010-02-01 10:18:41 EST
Starting this bug in p2, but I have the feeling this may be a Platform-UI bug.

1) Start an update process and send it to the background.

2) While update is running bring up the preferences and do something that will bring up a modal dialog (e.g. Preferences->General->Security->Secure Storage->Content->Delete this should bring up a dialog asking you if you really want to delete).  Leave this dialog up until p2 finishes the update and brings the dialog up asking you to restart Eclipse.

Now you have two modal dialogs but both will not function, I cannot cancel out of either and I am left with a "hung" Eclipse.
Comment 1 Susan McCourt CLA 2010-02-01 12:42:51 EST
This is a rather (in)famous problem, caused by improper shell parenting.  Sounds like another case.  See bug 231150.

Either:
- p2 code has changed so that the "get the right parent" code is not being called
- there is a bug in the logic
Comment 2 Susan McCourt CLA 2010-02-01 12:44:00 EST
marking M6 as that is when I planned to look at the platform UI side of things
Comment 3 Susan McCourt CLA 2010-02-17 14:34:05 EST
Tom, I can't reproduce this on Win7.
Can you reproduce this at will (by leaving that prompt dialog open) or does it require specific timing?  

I'm trying to determine if this is a Mac-only bug or not.

I was able to install/update/uninstall with that dialog open and the correct parenting occurred.  I also confirmed that the "you are about to install unsigned content" dialog is also correctly parented.
Comment 4 Thomas Watson CLA 2010-02-17 14:50:10 EST
I only tried this on the mac and I did try it several times and was able to reproduce it every time.  If I remember correctly I would perform a rollback, restart, check for updates again and be able to reproduce it every time.

I try it again when updating to today's build.
Comment 5 Thomas Watson CLA 2010-02-18 08:59:36 EST
I just reproduced this again updating to yesterdays build from the 20090209 build on Mac Cocoa.  I don't think it is a timing issue.  As long as another modal dialog is up before p2 displays its modal dialog then I would be hung.  This time I was updating SVN also which contains unsigned bundles so I got the Security Warning dialog from p2.  But the result was the same.  I could not get either dialogs to respond.
Comment 6 Susan McCourt CLA 2010-02-18 11:15:02 EST
Tom, do you have a 3.5 that you could try this on?  I'm curious if this is a regression or if it's a Mac-only problem that's been around.  I'm suspecting it's the latter.

Does not happen on Win7.

Remy, is it straightforward for you to try this on Linux/GTK?  If not, I can try later on today myself.

I'm going to move this to Platform UI since I believe it's an issue with the algorithm for avoiding multiple modal shells.  I'm working in this area in bug 231150.  Marking 3.6 to keep it on the radar.

cc'ing Christopher - have you heard of the "error dialog on top?" problem still existing on the Mac?
Comment 7 Thomas Watson CLA 2010-02-19 11:29:22 EST
(In reply to comment #6)
> Tom, do you have a 3.5 that you could try this on?  I'm curious if this is a
> regression or if it's a Mac-only problem that's been around.  I'm suspecting
> it's the latter.

I just tried this on 3.5.0 and updating to 3.5.1 with the galileo repo.  Both dialogs are displayed, the secure storage and the restart dialog.  I was not able to do anything with the secure storage dialog (so I thought I was hung), but then I tried the restart dialog by clicking NO and it worked and I was then able to dismiss the secure storage dialog.  I'm pretty sure that was not possible on my latest tests on 3.6.
Comment 8 Susan McCourt CLA 2010-04-24 20:03:41 EDT
We are using the (new-ish) platform UI API to get the parent.
I suspect there's a bug in ProgressManagerUtil.
Moving to Prakash since he is watching both progress and Mac bugs.
Comment 9 Eclipse Webmaster CLA 2019-09-06 16:03:29 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.