Bug 300862 - Change buttons order in PathVariableDialog
Summary: Change buttons order in PathVariableDialog
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.6   Edit
Hardware: PC Windows XP
: P3 trivial (vote)
Target Milestone: 3.6 M6   Edit
Assignee: Serge Beauchamp CLA
QA Contact:
URL:
Whiteboard:
Keywords: polish
Depends on:
Blocks:
 
Reported: 2010-01-26 11:32 EST by Tomasz Zarna CLA
Modified: 2010-02-02 05:07 EST (History)
1 user (show)

See Also:

Attachments
Fix v01 (1.86 KB, patch)
2010-01-27 08:59 EST, Tomasz Zarna CLA 		no flags Details | Diff
mylyn/context/zip (2.79 KB, application/octet-stream)
2010-01-27 08:59 EST, Tomasz Zarna CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomasz Zarna CLA 2010-01-26 11:32:17 EST 
IMHO more intuitive order for buttons in PathVariableDialog would be [File...][Folder...][Variable...] instead of [File...][Variable...][Folder...]. I can provide a patch if the swap makes sense to you too ;)
Comment 1 Serge Beauchamp CLA 2010-01-26 11:38:30 EST 
That sounds fine to me, I'd always welcome a patch :)
Comment 2 Tomasz Zarna CLA 2010-01-27 08:59:19 EST 
Created attachment 157395 [details]
Fix v01

Here you go.
Comment 3 Tomasz Zarna CLA 2010-01-27 08:59:24 EST 
Created attachment 157396 [details]
mylyn/context/zip
Comment 4 Serge Beauchamp CLA 2010-02-01 09:51:00 EST 
This is now fixed on HEAD
Comment 5 Tomasz Zarna CLA 2010-02-02 05:07:52 EST 
Verified in HEAD. Thanks Serge.