Bug 300620 - Command+. does not work any more in Trees
Summary: Command+. does not work any more in Trees
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 3.6   Edit
Hardware: PC Mac OS X
: P3 major (vote)
Target Milestone: 3.7 M3   Edit
Assignee: Scott Kovatch CLA
QA Contact: Silenio Quarti CLA
URL:
Whiteboard:
Keywords:
: 328504 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-01-24 14:47 EST by Markus Keller CLA
Modified: 2010-10-29 05:01 EDT (History)
6 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2010-01-24 14:47:11 EST 
Broken in I20100119-0800 and 3.5 Cocoa, works in 3.4.2 Carbon.

Command+. does not work any more in Trees. I just get an OS beep, and the KeyDown event for Command+. is missing.

In Eclipse, this is e.g. visible in the Search view, where Command+. should step to the next match. The reverse (Command+Shift+.) still works.

In the Java Editor, Command+. still works (jumps to next annotation).
Comment 1 Kevin Barnes CLA 2010-02-18 15:26:42 EST 
No key event is coming from the OS in this case. Not sure why we get the key event on Shell, but not on Tree. Cmd-Period is a native keybinding to close a dialog - maybe that's related somehow.
Comment 2 Scott Kovatch CLA 2010-05-07 00:23:22 EDT 
See http://src.chromium.org/svn/branches/375/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm

Look for _wantsKeyDownForEvent. We need to implement this to return true on anything that can be a first responder. By doing that we will get cmd-. and a collection of other keys we special-case right now in Shell.windowSendEvent.
Comment 3 Dani Megert CLA 2010-10-23 03:22:09 EDT 
Either we need to fix this or add a README entry.
Comment 4 Dani Megert CLA 2010-10-23 03:23:08 EDT 
*** Bug 328504 has been marked as a duplicate of this bug. ***
Comment 5 Scott Kovatch CLA 2010-10-24 17:15:34 EDT 
This was bulk-moved to SWT-triaged when Kevin left. Yes, we should fix this, as it would take care of cmd-. not being processed as a dialog-cancel message, either.
Comment 6 Scott Kovatch CLA 2010-10-25 13:31:08 EDT 
I'm wrong on two conclusions today. First, _wantsKeyDownForEvent covers everything _but_ command-., in my testing. That's because command-. is handled as cancelOperation:, which gets sent to the first responder. That's easy to implement, and it's API. The code in Shell for special processing of ctrl-page up, down, etc. works, and switching to SPI, even though it's shown in WebKit isn't a good idea, so I'll leave that alone for now.

Fixed in HEAD > 20101025. The UI layer should add a key binding for command-. in a dialog that maps to the Cancel button.
Comment 7 Markus Keller CLA 2010-10-29 05:01:13 EDT 
Verified in I20101028-1441.

> The UI layer should add a key binding for command-.
> in a dialog that maps to the Cancel button.

Bug 278627.