Community
Participate
Working Groups
A preference is to be added to enable current line highlight, default value false. The preference should appear under *Tasks -> Task Editing* in the Eclipse preferences. WikiText task editor extension to be modified to use this preference for enabling current line highlight. After this enhancement current line highlight will be disabled by default in the task editor when WikiText is used. Enhancement based on conference call discussion.
Created attachment 156155 [details] indication of where the new preference should appear.
Created attachment 156191 [details] patch that implements the enhancement Attached a working patch. The only thing I don't like about this is that it introduces the use of tasks.ui internals into wikitext.tasks.ui.
Created attachment 156192 [details] mylyn/context/zip
Fixed in CVS
David, would you be okay with back-porting the WikiText change to 3.3.2? Otherwise I would have to revert the changes to tasks ui for the maintenance release. For 3.4 we could also consider making this API, e.g. adding a method to TasksUiUtil that returns whether highlighting is enabled.
(In reply to comment #5) > David, would you be okay with back-porting the WikiText change to 3.3.2? > Otherwise I would have to revert the changes to tasks ui for the maintenance > release. The ugly head of CVS rises once again! Can't the maintenance release be built off a tag? BTW, I don't mind backporting the change. What tag should I be using on org.eclipse.mylyn.wikitext.tasks.ui ? > For 3.4 we could also consider making this API, e.g. adding a method to > TasksUiUtil that returns whether highlighting is enabled. Great
(In reply to comment #6) > (In reply to comment #5) > > David, would you be okay with back-porting the WikiText change to 3.3.2? > > Otherwise I would have to revert the changes to tasks ui for the maintenance > > release. > > The ugly head of CVS rises once again! Can't the maintenance release be built > off a tag? Yes, I am planning to tag the release and to then build from that tag. It's not so much the fault of CVS that we don't branch but rather laziness of the release engineer who wants to keep the number of parallel branches that need to be maintained to a minimum... > BTW, I don't mind backporting the change. What tag should I be using on > org.eclipse.mylyn.wikitext.tasks.ui ? I'll have to setup a workspace and create a branch anyways so I can take care of that. I'll post the patch here so you can review. > > For 3.4 we could also consider making this API, e.g. adding a method to > > TasksUiUtil that returns whether highlighting is enabled. > > Great I have opened bug 300065 to track that.
(In reply to comment #7) > I'll have to setup a workspace and create a branch anyways so I can take care of > that. I'll post the patch here so you can review. Great, thanks for taking care of that.
Created attachment 157273 [details] backported patch
I have committed the attached patch to the e_3_6_m_3_3_x branch and did a quick smoke test.
