Community
Participate
Working Groups
We will add a tweaklet to 3.6 that will allow us to replace some of the use of internals in our ApiTestSuite. ex: WorkbenchPage page = (WorkbenchPage) fPage; to WorkbenchPageHelper page = tweaklet.createWorkbenchPage(fPage); Each helper will provide the method signatures of the original and in 3.6 will simply cast and delegate internally. In e4, then we can "play". PW
haha ... an interesting corrollary is that the helper must return other helpers for internal classes ... that means no Perspective or IActionSetDescriptor. PW
Created attachment 156399 [details] api test helper approach v01 This way of fixing the tests involves providing helpers for any internals that the tests need. Then in 3.x we have delegators and in e4 we will need to cook up some equivalent. There is another option ... instead of creating object helpers, create test helpers. Methods on the tweaklet with as many parameters as needed, and do the cast-to-internals/asserts in there. Then we provide the e4 "equivalent" test/assert in our e4 tweaklet ... this means we can provide equivalent tests, but we have to be careful that our tests amount to the same thing. Boris, Remy, what do you think we should try. PW
OK, after talking to Remy I'll attach a patch where it is a test helper, not a internal object helper and see how that goes. Also, we'll have to modify the static that adds the default to use reflection so it doesn't choke in e4. PW
Created attachment 156419 [details] api test facade v01 This takes the other approach. Delegate requests for internal information to the test facade. Allow it to assert conditions if necessary. The facade methods will only take API. PW
(In reply to comment #4) > Created an attachment (id=156419) [details] > api test facade v01 I've released this into o.e.ui.tests HEAD. I've added another plugin to the e4.compat.psf that provides the e4 tweaklet and updated MANIFEST.MFs so that everybody can see the right classes at runtime. PW
Created attachment 158490 [details] Test Facade v03 Released to HEAD PW
I've released changes to the e4 tweaklet as they were missing the concrete implementations of the abstract methods.
Updated ViewUtil for the StickyView tests. PW
