Bug 29939 - Avoid redundant code and share more code
Summary: Avoid redundant code and share more code
Status: RESOLVED DUPLICATE of bug 37716
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Resources (show other bugs)
Version: 2.1   Edit
Hardware: PC Windows 2000
: P3 major (vote)
Target Milestone: ---   Edit
Assignee: Platform-Resources-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 32499
Blocks:
  Show dependency tree
 
Reported: 2003-01-22 01:05 EST by Gunnar Wagenknecht CLA
Modified: 2003-08-07 11:34 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Gunnar Wagenknecht CLA 2003-01-22 01:05:19 EST
From a newsgroup discussion:
-----------------------
"Frank Budinsky" <frankb@ca.ibm.com> schrieb im Newsbeitrag 
news:3E0C7A28.19F7EDA1@ca.ibm.com...

> How about GEF provide an alternate packaging for EMF users, gef_for_emf.zip, 
or
> something like that, that doesn't include it's own copy of the common command
> interfaces, but instead "requires" the EMF ones to be there.

Why? How about make a seperate "command" package that can be shared not only 
between GEF and EMF? It can be publicized via an "Eclipse Common Tools" page.

It's always the same. There are a lot of good implementations in several 
Eclipse plugins and every plugin copies the code insted of sharing it. It's 
really anoying. Look into CDT and JDT they have complete redundant UI packaged 
which could be really helpfull for other developers.
-----------------------------

I don't know where it will fit best because IMHO all components are involved. 
Please feel free to move it and share it between the possible components.

I'd like to see an "Eclipse Common Tools" project which covers redundant code 
that can be shared across two or more plug-ins.
Comment 1 Erich Gamma CLA 2003-02-21 04:43:20 EST
>Look into CDT and JDT they have complete redundant UI packaged 
>which could be really helpfull for other developers.
CDT had to copy a lot of code to be feature compatible with the Java editor in 
2.0.

In 2.1 we have pushed down a lot of the Java Editor features into the base 
platform. It is now up to the components to migrate from their copied to code 
to the platform provided code.

I don't say we have fully solved this problem but we made good progress.
Comment 2 Gunnar Wagenknecht CLA 2003-02-21 06:42:17 EST
Good to hear. What about the custom "Dialogs" (StatusDialog and subclasses) 
with the "DialogFields". It's IMHO a usefully framework.

Cu, Gunnar
Comment 3 Erich Gamma CLA 2003-02-21 10:08:27 EST
DialogFields have the status of an internally used framework only. If you would 
like to get it promoted to a published framework/API then please post a 
separate feature request against Platform UI.
Comment 4 Gunnar Wagenknecht CLA 2003-02-21 12:49:29 EST
filled as bug 32499
Comment 5 Gunnar Wagenknecht CLA 2003-08-07 09:55:57 EDT
The forms UI framework used by plugin.xml editor and update manager UI is 
another possible candidate to share code.

I think it is a good idea to reference all related bug reports here. IMHO 
the "depends on" field is a good candidate.
Comment 6 Randy Hudson CLA 2003-08-07 10:27:12 EDT
This request seems to cover many topics.  See bug 37716.  I would suggest 
resolving this as a duplicate of that 3.0 plan item, and if there are any other 
candidates (other than commands and 32499), open additional bugzillas to track 
each.
Comment 7 John Arthorne CLA 2003-08-07 11:34:45 EDT
Agreed.  Please enter more specific API feature requests where you think sharing
would be useful.

*** This bug has been marked as a duplicate of 37716 ***