Bug 297681 - [Preferences] PlatformUIPreferenceListener should log exceptions instead of printing them
Summary: [Preferences] PlatformUIPreferenceListener should log exceptions instead of p...
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.6   Edit
Hardware: All All
: P3 minor (vote)
Target Milestone: 3.8 M3   Edit
Assignee: Remy Suen CLA
QA Contact: Oleg Besedin CLA
URL:
Whiteboard:
Keywords: bugday, helpwanted
Depends on:
Blocks:
 
Reported: 2009-12-12 22:21 EST by Remy Suen CLA
Modified: 2011-10-25 14:45 EDT (History)
2 users (show)

See Also:

Attachments
Patch for Bug 297681 (1.96 KB, patch)
2011-09-20 09:57 EDT, Shahin Kahriz CLA 		no flags Details | Diff
Patch for Bug 297681 (2.10 KB, patch)
2011-10-12 15:27 EDT, Shahin Kahriz CLA 		remy.suen: iplog+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Remy Suen CLA 2009-12-12 22:21:57 EST 
Please refer to line 152 and line 158. A rather trivial bug that someone from the community can help with. :)
Comment 1 Shahin Kahriz CLA 2011-09-20 09:57:47 EDT 
Created attachment 203681 [details]
Patch for Bug 297681

Exceptions are now being logged instead of printed.
Comment 2 Remy Suen CLA 2011-09-20 10:12:20 EDT 
(In reply to comment #1)
> Created attachment 203681 [details]
> Patch for Bug 297681

1. Don't include extra whitespace changes, you added some between the package statement and the import statements.

2. Don't use java.util.logging.Logger. The WorkbenchPlugin class has several static log(*) methods. Pick an appropriate one and use that instead.

3. The subject/first line of the commit message should be the bug number and the summary itself (it will definitely wrap to the second line, this is okay):

Bug 297681 [Preferences] PlatformUIPreferenceListener should log exceptions instead of printing them

Afterwards, include two line breaks and then enter a description of the commit. Although I realize in this case the description is practically identical to what's in the subject but this is how commit messages usually are in Git and it would be good of you to familiarize yourself with Git "coding" standards.

4. Get your global user.name and user.email setup correctly so that it shows your name and your email in the author field. Right now it seems to be off a bit.
Comment 3 Shahin Kahriz CLA 2011-10-12 15:27:48 EDT 
Created attachment 205065 [details]
Patch for Bug 297681

Steps 1-4 completed from previous comment. There were problems while trying to apply patch - fix was to ignore first few lines of patch file.
Comment 4 Remy Suen CLA 2011-10-12 16:20:23 EDT 
(In reply to comment #3)
> Created attachment 205065 [details]
> Patch for Bug 297681

Thanks Shahin. I'll get this in before M3 goes out.
Comment 6 Remy Suen CLA 2011-10-25 14:45:08 EDT 
Verified by code inspection with I20111025-0808 on Windows XP. Thanks, Shahin!