Bug 297335 - [Dialogs] [UX] Resource Filters button on NewFolder wizard should expand a filter section ?
Summary: [Dialogs] [UX] Resource Filters button on NewFolder wizard should expand a fi...
Status: ASSIGNED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.6   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Serge Beauchamp CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-09 08:46 EST by Szymon Brandys CLA
Modified: 2019-09-06 16:12 EDT (History)
2 users (show)

See Also:


Attachments
screenshot proposal (42.19 KB, image/png)
2010-01-07 15:02 EST, Serge Beauchamp CLA
no flags Details
Implementation (8.48 KB, patch)
2010-01-07 15:12 EST, Serge Beauchamp CLA
no flags Details | Diff
An expandlable section (24.92 KB, image/png)
2010-01-08 04:52 EST, Szymon Brandys CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Szymon Brandys CLA 2009-12-09 08:46:36 EST
NewFolder wizard allows to add Resource Filters to newly created folder. There is the Resource Filters button in the Advanced section that opens a dialog. However if you want to add a filter, you have to press "Add" what opens yet another dialog. 

I think that the "Resource Filters" button could expand a filter section instead of opening a dialog. This would limit the number of dialogs opened while adding a filter.
Comment 1 Szymon Brandys CLA 2009-12-09 08:49:01 EST
The discussion and the fix (if we agree that one is needed) should be done by M5.
Comment 2 Serge Beauchamp CLA 2010-01-04 10:16:37 EST
I agree that this change would be an improvement in the UI.
Comment 3 Serge Beauchamp CLA 2010-01-07 15:02:36 EST
Created attachment 155540 [details]
screenshot proposal

I feel like transforming the "Resource Filter" button so it behaves like the 'advanced' button would be awkward, since it would be an "advanced advanced" setting.  Instead, I suggest to place the filter groups directly in the advanced section (see attached screenshot).

What do you think?
Comment 4 Serge Beauchamp CLA 2010-01-07 15:12:12 EST
Created attachment 155543 [details]
Implementation
Comment 5 Szymon Brandys CLA 2010-01-08 04:51:25 EST
(In reply to comment #3)
> I feel like transforming the "Resource Filter" button so it behaves like the
> 'advanced' button would be awkward, since it would be an "advanced advanced"
> setting. 

I agree. We could perhaps add "Resource Filter" button on the same level as "Advanced" button, it would look weird though. We could also use an expandable section like the Java Project wizard. I'm attaching a screenshot illustrating this approach.

Moreover I think that the details explaining what are "Resource Filters" should be rather in a tooltip.
Comment 6 Szymon Brandys CLA 2010-01-08 04:52:35 EST
Created attachment 155582 [details]
An expandlable section
Comment 7 Serge Beauchamp CLA 2010-01-08 06:43:13 EST
(In reply to comment #5)
> (In reply to comment #3)
> > I feel like transforming the "Resource Filter" button so it behaves like the
> > 'advanced' button would be awkward, since it would be an "advanced advanced"
> > setting. 
> 
> I agree. We could perhaps add "Resource Filter" button on the same level as
> "Advanced" button, it would look weird though. We could also use an expandable
> section like the Java Project wizard. I'm attaching a screenshot illustrating
> this approach.
> 
I think it's a good idea.  I think we should replace the 'advanced' button by an expandable widget, I always though the button looked clunky.

Regarding having both an advanced and a filter expandable, don't you think the behavior wouldn't be optimal, especially considering that it resizes the window each time one of the section is expanded?

> Moreover I think that the details explaining what are "Resource Filters" should
> be rather in a tooltip.

That widget only re-use the one that is placed in the property page.  Do you think it should be a tooltip in the properly pages too or only there?
Comment 8 Szymon Brandys CLA 2010-01-08 10:46:13 EST
(In reply to comment #7)
> Regarding having both an advanced and a filter expandable, don't you think the
> behavior wouldn't be optimal, especially considering that it resizes the window
> each time one of the section is expanded?

This would not be an issue for me. Susan, what do you think?

> That widget only re-use the one that is placed in the property page.  Do you
> think it should be a tooltip in the properly pages too or only there?

Regarding the properties page, I think that details how to use filters should be rather shown in the help section (the help tray). If we did it, we could just remove the description from the page or maybe replace with something like we have on other pages, i.e "The page allows you to manage Resource Filters" what is obvious looking at the page title :-)
Comment 9 Susan McCourt CLA 2010-01-21 12:03:40 EST
(In reply to comment #8)
> (In reply to comment #7)
> > Regarding having both an advanced and a filter expandable, don't you think the
> > behavior wouldn't be optimal, especially considering that it resizes the window
> > each time one of the section is expanded?
> 
> This would not be an issue for me. Susan, what do you think?

Sorry I'm so late in commenting on this bug.
I think the expandable section is nice.  I prefer having two rather than one very busy one, (though I'd have to see it in action to be sure).  I also think that if we go this way, we should rename "Advanced" to "Location" because at this point we are separating different advanced concepts into their own sections. The "Advanced" button only makes sense if we continue to group everything in one section. 

If these are not in separate sections, we need a better separation of the two areas.  I realize you are trying to reuse the widgetry, but having the group border around the filters part seems odd/inconsistent in the merged section (since the location stuff doesn't have one).  
> 
> > That widget only re-use the one that is placed in the property page.  Do you
> > think it should be a tooltip in the properly pages too or only there?
> 
> Regarding the properties page, I think that details how to use filters should
> be rather shown in the help section (the help tray). If we did it, we could
> just remove the description from the page or maybe replace with something like
> we have on other pages, i.e "The page allows you to manage Resource Filters"
> what is obvious looking at the page title :-)

I agree with Szymon here.  We don't try to educate the user in the page title anywhere else, let's keep the text simple and just ensure that the context help is sufficient.
Comment 10 Susan McCourt CLA 2010-01-26 11:23:54 EST
Are we punting this to M6?
Comment 11 Serge Beauchamp CLA 2010-01-26 11:29:14 EST
changing the target to M6
Comment 12 Susan McCourt CLA 2010-03-09 18:23:18 EST
assuming this is going to M7
(it shows up on my verify list since i'm QA contact)
Comment 13 Serge Beauchamp CLA 2010-04-15 09:21:22 EDT
removing target, since unsure about it.
Comment 14 Eclipse Webmaster CLA 2019-09-06 16:12:37 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.