Bug 297254 - [api] allow disabling of repository creation for a connector
Summary: [api] allow disabling of repository creation for a connector
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P2 enhancement (vote)
Target Milestone: 3.4   Edit
Assignee: Thomas Ehrnhoefer CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed, noteworthy
Depends on:
Blocks:
 
Reported: 2009-12-08 14:08 EST by Thomas Ehrnhoefer CLA
Modified: 2010-05-28 12:38 EDT (History)
2 users (show)

See Also:

Attachments
mylyn/context/zip (5.09 KB, application/octet-stream)
2009-12-08 14:18 EST, Steffen Pingel CLA 		no flags Details
patch v1 (3.89 KB, patch)
2009-12-08 14:56 EST, Thomas Ehrnhoefer CLA 		no flags Details | Diff
mylyn/context/zip (17.32 KB, application/octet-stream)
2009-12-08 14:56 EST, Thomas Ehrnhoefer CLA 		no flags Details
patch v2 (4.97 KB, patch)
2009-12-08 16:11 EST, Thomas Ehrnhoefer CLA 		thomas.ehrnhoefer: review?
Details | Diff
mylyn/context/zip (8.98 KB, application/octet-stream)
2009-12-08 16:11 EST, Thomas Ehrnhoefer CLA 		no flags Details
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Ehrnhoefer CLA 2009-12-08 14:08:46 EST 
Sometimes a connector has a reason to prohibit the user from creating a task repository by itself (e.g. the connector manages it's task repositories some other way).
Comment 1 Steffen Pingel CLA 2009-12-08 14:18:51 EST 
Thomas, would you be interested in providing a patch? I think it should be as simple as adding a AbstractRepositoryConnector.canCreateRepository() method that is checked in the relevant places (see context).
Comment 2 Steffen Pingel CLA 2009-12-08 14:18:55 EST 
Created attachment 154046 [details]
mylyn/context/zip
Comment 3 Thomas Ehrnhoefer CLA 2009-12-08 14:56:23 EST 
Created attachment 154051 [details]
patch v1

This might do the trick (works in my test scenario). Hope I did not forget another entry point for adding a repository...
Comment 4 Thomas Ehrnhoefer CLA 2009-12-08 14:56:27 EST 
Created attachment 154052 [details]
mylyn/context/zip
Comment 5 Steffen Pingel CLA 2009-12-08 15:51:40 EST 
Please take a look at TaskRepositoryParameterValues. I believe it may need a filter as well or the command contribution for adding a task repository needs to be modified.
Comment 6 Thomas Ehrnhoefer CLA 2009-12-08 16:11:38 EST 
Created attachment 154058 [details]
patch v2

Do you mean something like that?
Comment 7 Thomas Ehrnhoefer CLA 2009-12-08 16:11:45 EST 
Created attachment 154059 [details]
mylyn/context/zip
Comment 8 Steffen Pingel CLA 2009-12-08 16:38:03 EST 
Yes, that looks good. I'll merge this once we are increasing version numbers to 3.4.
Comment 9 Thomas Ehrnhoefer CLA 2009-12-08 16:49:46 EST 
great, thanks.
Comment 10 Steffen Pingel CLA 2010-02-03 14:14:18 EST 
Patch applied to head. Thanks Thomas!