Bug 296262 - [Sync View] Linking from editor to Synchronize view does not work with Change Sets
Summary: [Sync View] Linking from editor to Synchronize view does not work with Change...
Status: CLOSED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Team (show other bugs)
Version: 3.6   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform Team Inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords:
Depends on:
Blocks: 297055
  Show dependency tree
 
Reported: 2009-11-26 12:03 EST by Markus Keller CLA
Modified: 2021-12-17 12:41 EST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2009-11-26 12:03:39 EST
I20091124-0800

Non-model synchronization, Outgoing Mode: Linking from editors to the Synchronize view does not work when Change Sets are enabled but the corresponding change set has never been expanded before in this session. Without Change Sets or after expanding the Change Set, it works fine.
Comment 1 Tomasz Zarna CLA 2010-03-02 10:26:57 EST
As a consequence of expanding a Change Set, projects being children of the set are associated with corresponding widgets[1]. That's why once the Change Set has been expanded the viewer is able to find and select[2] a widget for a file from the activated editor. Actually, it is possible because the viewer also checks parent of the file to be selected[3] and when needed creates required widgets[4]. The problem is that the parent will never be a ChangeSetDiifNode (Change Set element in the Sync view) since we use WorkbenchAdapter to get the parent[5] and we will eventually stop at root (WorkspaceRoot)[2][6].

I'm still trying to figure out a possible way of fixing this...

[1] org.eclipse.jface.viewers.StructuredViewer.mapElement(Object, Widget)
[2] org.eclipse.jface.viewers.AbstractTreeViewer.internalExpand(Object, boolean)
[3] org.eclipse.jface.viewers.AbstractTreeViewer.getParentElement(Object)
[4] org.eclipse.jface.viewers.AbstractTreeViewer.createChildren(Widget)
[5] org.eclipse.ui.model.BaseWorkbenchContentProvider.getParent(Object)
[6] org.eclipse.jface.viewers.AbstractTreeViewer.doFindInputItem(Object)
Comment 2 Markus Keller CLA 2010-03-02 10:41:45 EST
Sounds like a bug in the content provider then. The one who returns change sets as root elements also needs to override getParent(Object) and return a change set where necessary.
Comment 3 Eclipse Webmaster CLA 2019-09-06 15:37:43 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.
Comment 4 Eclipse Genie CLA 2021-12-17 12:41:36 EST
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.