Bug 296156 - [Contributions] Make ContributionItemFactory items usable for org.eclipse.ui.menus
Summary: [Contributions] Make ContributionItemFactory items usable for org.eclipse.ui....
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.5.1   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-25 12:07 EST by Ralf Ebert CLA
Modified: 2019-09-06 15:35 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ralf Ebert CLA 2009-11-25 12:07:06 EST 
ContributionItemFactory should implement IExecutableExtensionFactory so you can use the contribution items using the "org.eclipse.ui.menus" extension point (similar to ExtensionFactory) like this:

         <menu
               id="window"
               label="%Window">
            <dynamic
                  class="com.example.addressbook.ShowViewMenuFactory"
                  id="org.eclipse.ui.actions.ContributionItemFactory:viewsShortlist">
            </dynamic>
         </menu>
         
Workaround is to use the ActionBarAdivsor or to create an own factory for this:

public class ShowViewMenuFactory implements IExecutableExtensionFactory {

	@Override
	public Object create() throws CoreException {
		return ContributionItemFactory.VIEWS_SHORTLIST.create(PlatformUI.getWorkbench().getActiveWorkbenchWindow());
	}

}

Problem is, how do you obtain the workbench window in such a factory? Using PlatformUI works, but feels inappropriate.
Comment 1 Eclipse Webmaster CLA 2019-09-06 15:31:57 EDT 
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.
Comment 2 Eclipse Webmaster CLA 2019-09-06 15:35:36 EDT 
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.