Community
Participate
Working Groups
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1.4) Gecko/20091016 Firefox/3.5.4 (.NET CLR 3.5.30729) Build Identifier: Trac 3.3.x Trac / Mylyn supports using client-certificates for https-connections. However, as all informations are passed on as Java-Variable it seems unhandy: A password may be visible, and you cannot have two different certificates for two Task-Repositories. I have added this functionality and created a patch. Testing was limited (I had problems building a proper update-site), but done within the IDE and also with Eclipse 3.5 SR1 on Linux and MacOS. It would be great, if you can review my patch and submit it into Mylyn. Reproducible: Always Steps to Reproduce: (feature request)
Created attachment 152140 [details] Patch for my change-request
Thanks for the patch. That's a great a feature addition and the implementation looks very good! I would like to change on minor detail. Instead of prompting the user for the client certificate details in case of a handshake failure I think it's better to propagate the exception. The handshake could fail for many reasons and it could be confusing to get a prompt for a client certificate in that case. It could make sense to validate the password though in case opening the keystore fails, right now an exception is logged but it would be nice if the user was informed instead and given an opportunity to enter the correct password. Does that make sense? If you are interested in making these changes and post a new iteration I can go ahead and submit the patch for IP review to the Eclipse Foundation (that's the standard process for patches exceeding 250 lines of code).
Created attachment 152510 [details] mylyn/context/zip
Thanks Steffen! I will do the changes and post a new patch soon. I have looked again at the code and found the excpetion. So I would not add a password-dialog to the SSL-Factory, but rather catch the exception and throw a new one. This can be catched by the caller and reacted accordingly. At least the repository-properties dialog needs a different handling (= update the user message at the top) compared to other actions (= pop up a password dialog).
Created attachment 152701 [details] Patch -- 2nd iteration.
Thanks Torsten. The patch looks very good. I have submitted a CQ to get the patch IP reviewed by the Eclipse Foundation so that we can hopefully apply the changes for the 3.4 release.
Thanks Steffen for your effort ... I confirm that: 1. I am authored 100% of the material 2. I do have the rights to donate the content to Eclipse 3. I am contributing the content under the EPL -- Torsten.
Thanks Torsten. The CQ got approved. I'm planning to get the patch applied within the next three weeks.
Unfortunately I'll have to postpone merging this patch until bug 304755 is resolved which blocks changes to the org.eclipse.mylyn.commons.net plug-in. I am definitely still planning to get this in for the 3.4 release.
Sorry, this fell of the plate for 3.4 and we are now to close to the release to make this change. I aim to get this in early for 3.5.
Sorry, I didn't get around to applying the patch. I will try again for 3.6.
Thanks for being so patient, Torsten, and thanks a lot for this great contribution! I have finally gotten around to working on the patch and will commit it to head shortly. I'll mark this bug as resolved to include the contribution in the IP log. I'll track any remaining work ob bug 178122.
Created attachment 196386 [details] updated patch
Created attachment 196390 [details] fix layout problem
Created attachment 197039 [details] settings dialog
