Bug 293888 - Consider adding line-numbers to the editor by default
Summary: Consider adding line-numbers to the editor by default
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: IDE4EDU (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted
Depends on:
Blocks:
 
Reported: 2009-11-01 22:59 EST by Dennis Acosta CLA
Modified: 2014-01-09 15:38 EST (History)
5 users (show)

See Also:


Attachments
Patch to display line numbers in the editor by default (1.12 KB, patch)
2009-11-02 20:36 EST, Dennis Acosta CLA
no flags Details | Diff
Patch to display line numbers in the editor by default (2.84 KB, patch)
2009-11-02 20:44 EST, Dennis Acosta CLA
no flags Details | Diff
Updated patch to show line numbers by default (7.26 KB, patch)
2010-01-24 17:10 EST, Cory Matheson CLA
no flags Details | Diff
Line numbers display on start-up (845 bytes, patch)
2011-06-09 13:33 EDT, Mike Martino CLA
wayne.beaton: iplog+
Details | Diff
mylyn/context/zip (648 bytes, application/octet-stream)
2011-06-23 14:07 EDT, Wayne Beaton CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Dennis Acosta CLA 2009-11-01 22:59:25 EST
The results from two IDE usability surveys suggest that beginner programmers find the line-numbers "ruler" useful. Perhaps it should be available by default.

http://docs.google.com/present/view?id=addqfjnjc3d6_108gj3w67c3
http://proton.scs.carleton.ca/~dacosta/ide4edu/results.ods
Comment 1 Dennis Acosta CLA 2009-11-02 20:36:57 EST
Created attachment 151146 [details]
Patch to display line numbers in the editor by default
Comment 2 Dennis Acosta CLA 2009-11-02 20:44:53 EST
Created attachment 151147 [details]
Patch to display line numbers in the editor by default

Please ignore the previous patch.
Comment 3 Cory Matheson CLA 2010-01-24 17:10:53 EST
Created attachment 157064 [details]
Updated patch to show line numbers by default

Made some tweaks to the previously proposed patch so that its now more compatible with the current version of our project (logic adding the line numbers to the editor remains the same).
Comment 4 Wayne Beaton CLA 2010-02-16 15:55:20 EST
The approach you've taken here is novel. There is a mechanism in Eclipse that, using a customize product along with an ini file does the same thing. At some point, I believe that we're going to want to create our own product, so we should consider using that mechanism instead.

Having said that, I'm not 100% convinced that showing line numbers by default is necessarily good. Doesn't it add additional clutter to the screen? Can you argue that it's good clutter. I'm assuming that we have two "yes" votes. Does anybody else want to provide an opinion?
Comment 5 Cory Matheson CLA 2010-02-16 16:10:04 EST
(In reply to comment #4)
> Having said that, I'm not 100% convinced that showing line numbers by default
> is necessarily good. Doesn't it add additional clutter to the screen? Can you
> argue that it's good clutter. I'm assuming that we have two "yes" votes. Does
> anybody else want to provide an opinion?

Well, I'll add my opinion anyways :)..

I find seeing line numbers essential for development and debugging. The last thing I would want a new student to do is to go searching through Eclipse's massive options for where to enable it (in fact, would they even know it exists, or better yet, where the options are?). I find you get the best out of it when your debugging especially. Say you see a problem on line 27.. Its quicker to scroll to the line then try and guesstimate it.

And on that note, it only takes up an additional like.. 5mm of screen real estate? Its a very subtle additional that can go a long way to helping users out.

Although, I'm all for a more efficient (and less novel?) implementation if that is possible.
Comment 6 Brenda Sadoway CLA 2010-02-16 17:26:29 EST
I agree that having line numbers was useful to me as a beginner.  The default way for seeing line numbers, in the bottom right corner in the format "line:character" was not at all intuitive to me...  I would have at least preferred it above the console, closer to the editor where the actual code is, plus some hint that those numbers mean line and character position would have been nice.  Having a number next to each line was definitely a good idea once I figured out how to set that up.
Comment 7 Wayne Beaton CLA 2011-06-06 19:21:26 EDT
I believe that more correct way to accomplish this is to add an entry to the plugin_customization.ini file in org.eclipse.ide4edu.branding.

The FAQs tell us exactly what needs to be added :-)

http://wiki.eclipse.org/RCP_FAQ#How_can_I_show_line_numbers_by_default_in_my_RCP_application.3F

I'm marking the attachments as obsolete since we're not going to use them.
Comment 8 Wayne Beaton CLA 2011-06-08 12:38:37 EDT
FWIW, I'm leaving this one open for the time being as an 'easy one' for students to implement.
Comment 9 Mike Martino CLA 2011-06-09 13:33:06 EDT
Created attachment 197712 [details]
Line numbers display on start-up

Line numbers are now displayed on start-up.
Comment 10 Wayne Beaton CLA 2011-06-23 14:03:04 EDT
Thank Mike. 

Can you please confirm that:

(a) you wrote 100% of the code;  
(b) that you have the right to contribute the code to Eclipse;  and 
(c) the file header contains the appropriate License header.
Comment 11 Mike Martino CLA 2011-06-23 14:05:53 EDT
(In reply to comment #10)
> Thank Mike. 
> 
> Can you please confirm that:
> 
> (a) you wrote 100% of the code;  
> (b) that you have the right to contribute the code to Eclipse;  and 
> (c) the file header contains the appropriate License header.

Yes to a, b, and c.
Comment 12 Wayne Beaton CLA 2011-06-23 14:06:58 EDT
Patch committed. Marking as FIXED. Thanks Mike.
Comment 13 Wayne Beaton CLA 2011-06-23 14:07:00 EDT
Created attachment 198485 [details]
mylyn/context/zip