Bug 293551 - Columns are no longer displayed in the History view
Summary: Columns are no longer displayed in the History view
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: CVS (show other bugs)
Version: 3.6   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: 3.6 M4   Edit
Assignee: Pawel Pogorzelski CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 294392 296556 313480 (view as bug list)
Depends on: 274963 274964
Blocks:
  Show dependency tree
 
Reported: 2009-10-28 06:26 EDT by Frederic Fusier CLA
Modified: 2011-04-19 09:54 EDT (History)
7 users (show)

See Also:


Attachments
Patch_v01 (2.48 KB, patch)
2009-12-08 06:26 EST, Pawel Pogorzelski CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Frederic Fusier CLA 2009-10-28 06:26:44 EDT
Since build I20091025-2000, the history view desperately looks empty and unfortunately the problems still occurs with I20091027-0100.

It seems there are all the lines corresponding to the CVS versions of the selected file but there's no column at all in the table. So, when clicking on a line I normally get the contents of the file for the file, I also can compare two versions by selecting two different lines, but I cannot see any of the CVS information in this view.

Please fix it before M3 is delivered, this is a real big and annoying regression!
Comment 1 Remy Suen CLA 2009-10-28 06:32:23 EDT
I had this problem on Linux/gtk+ before but I've not seen this problem on Windows XP. It was certainly working when I tried at work yesterday.
Comment 2 Pawel Pogorzelski CLA 2009-10-28 06:55:39 EDT
The problem Remy mentioned is described at bug 274508. Frederic, could you have a look at comments 10 and 11?

If your case is different please provide more details to narrow the problem. Is is possible to reproduce with a fresh workspace or with a different CVS server? With given information I'm not able to reproduce it.
Comment 3 Frederic Fusier CLA 2009-10-28 08:03:08 EDT
(In reply to comment #2)
> The problem Remy mentioned is described at bug 274508. Frederic, could you 
> have a look at comments 10 and 11?
> 
> If your case is different please provide more details to narrow the problem. 
> Is is possible to reproduce with a fresh workspace or with a different CVS 
> server? With given information I'm not able to reproduce it.

Here are some more information:
 1) I cannot reproduce the problem using a fresh workspace,
 2) In all workspace I opened since build I20091025-2000 showing the problem, 
    the section for the history table provider in the dialog_settings.xml is 
    the same:
    <section name="org.eclipse.team.internal.ccvs.ui.CVSHistoryTableProvider">
        <item value="0" key="COL_DATE"/>
        <item value="0" key="COL_COMMENT"/>
        <item value="0" key="COL_TAGS"/>
        <item value="1024" key="SORT_COL_DIRECTION"/>
        <item value="COL_DATE" key="SORT_COL_NAME"/>
        <item value="0" key="COL_REVISIONID"/>
        <item value="0" key="COL_AUTHOR"/>
    </section>
 3) In a workspace not opened since several weeks, the dialog_settings.xml 
    didn't have a section for the history table provider. I opened this 
    workspace and the problem does not show up,
 4) I also couldn't reproduce the problem on a workspace not opened only since 
    10/22 and which has a 'normal' history section, e.g.:
    <section name="org.eclipse.team.internal.ccvs.ui.CVSHistoryTableProvider">
		<item value="112" key="COL_DATE"/>
		<item value="245" key="COL_COMMENT"/>
		<item value="72" key="COL_TAGS"/>
		<item value="1024" key="SORT_COL_DIRECTION"/>
		<item value="COL_DATE" key="SORT_COL_NAME"/>
		<item value="87" key="COL_REVISIONID"/>
		<item value="70" key="COL_AUTHOR"/>
    </section>
    I tried both with I20091025-2000 and I20091028-0100...
 5) Removing the offending section in the dialog_settings.xml fixes the problem
    and I can see the section back to 'normal' again after having closed my 
    workspace:
    <section name="org.eclipse.team.internal.ccvs.ui.CVSHistoryTableProvider">
		<item value="697" key="COL_COMMENT"/>
		<item value="130" key="COL_DATE"/>
		<item value="116" key="COL_TAGS"/>
		<item value="1024" key="SORT_COL_DIRECTION"/>
		<item value="COL_DATE" key="SORT_COL_NAME"/>
		<item value="129" key="COL_REVISIONID"/>
		<item value="75" key="COL_AUTHOR"/>
    </section>

So, as I have a workaround on workspaces having the problem and as it now becomes difficult to reproduce, I reduce the severity to major considering that if it happens for a common user, he or her can find it hard to figure out how to fix this issue...
Comment 4 Frederic Fusier CLA 2009-10-28 08:03:45 EDT
I also forgot to mention that I also got the same issue on my Windows Vista test box...
Comment 5 Pawel Pogorzelski CLA 2009-10-28 08:39:00 EDT
Frederic, are you able to restore column sizes with a mouse?
Comment 6 Szymon Brandys CLA 2009-10-28 09:07:46 EDT
(In reply to comment #5)
> Frederic, are you able to restore column sizes with a mouse?

I'm able to restore sizes on Windows XP, not able on Linux though.
Comment 7 Frederic Fusier CLA 2009-10-28 10:20:35 EDT
(In reply to comment #5)
> Frederic, are you able to restore column sizes with a mouse?

Yes, both on Win XP and Win Vista...
Comment 8 Frederic Fusier CLA 2009-10-28 10:34:40 EDT
Sorry, I didn't want to change those bugzilla fields...
Comment 9 Remy Suen CLA 2009-11-05 18:35:55 EST
*** Bug 294392 has been marked as a duplicate of this bug. ***
Comment 10 Pawel Pogorzelski CLA 2009-11-06 06:22:40 EST
(In reply to comment #9)
> *** Bug 294392 has been marked as a duplicate of this bug. ***

Thanks Remy. The problem seems to appear more often recently. In case SWT bugs this one depends on aren't resolved I'll release the patch from 274508 to work around the problem on CVS side.
Comment 11 Tomasz Zarna CLA 2009-12-03 05:07:09 EST
*** Bug 296556 has been marked as a duplicate of this bug. ***
Comment 12 Pawel Pogorzelski CLA 2009-12-03 05:43:48 EST
As it turns out this issue can't be handled in a reasonable way in SWT. I'll release the patch from 274508 in M4.
Comment 13 Pawel Pogorzelski CLA 2009-12-08 06:26:53 EST
Created attachment 153996 [details]
Patch_v01
Comment 14 Pawel Pogorzelski CLA 2009-12-08 06:30:28 EST
Patch_v01 in HEAD, marking as FIXED.
Comment 15 Tomasz Zarna CLA 2010-05-20 04:32:50 EDT
*** Bug 313480 has been marked as a duplicate of this bug. ***
Comment 16 Dani Megert CLA 2011-04-19 09:54:34 EDT
Cause for storing 0 could be bug 341865.