Community
Participate
Working Groups
HEAD. The new UI for resource filters needs polish: - missing mnemonics - fields not vertically aligned - wrong resize behavior - "Include Only"/"Exclude All" sounds strange: "Include"/"Exclude" is enough - only some Java developers know the syntax of java.util.regex.Pattern ==> don't use technical terms in the UI - regex pattern field should support content assist see: org.eclipse.jface.text.FindReplaceDocumentAdapterContentProposalProvider - "Arguments:" is wrong. Should be "Pattern:" or "Match string:" - all option labels must use sentence style - icons should be redone by a UI designer - labels that belong to disabled options must also be disabled
This should be addressed for M3. The icons may take a bit longer. It depends on our UI designers.
Thanks, I'll be looking into those issues. Btw, on what branch should they be made relative to? v20090820_e4merge?
(In reply to comment #2) > Btw, on what branch should they be made relative to? v20090820_e4merge? Serge, this is already in HEAD. Don't make any further changes to filters in v20090820_e4merge. Is M3 ok to you?
Assuming M3 means it has to be completed by the end of next week, then yes, it should be ready.
(In reply to comment #4) > Assuming M3 means it has to be completed by the end of next week, then yes, it > should be ready. Yes, next week. I would ask our UI designers to prepare icons, if you don't mind.
(In reply to comment #5) > (In reply to comment #4) > > Assuming M3 means it has to be completed by the end of next week, then yes, it > > should be ready. > > Yes, next week. I would ask our UI designers to prepare icons, if you don't > mind. That sounds great.
Most of the items below are now fixed on CVS HEAD, please see my comments below: (In reply to comment #0) > HEAD. > > The new UI for resource filters needs polish: > > - missing mnemonics The 'Add...', 'Edit...', 'Remove', 'Files'. 'Folders', 'Files and folders', 'Include', 'Exclude', 'Inheritable' now have mnemonic set. > - fields not vertically aligned The 'Match String' (previously 'Arguments'), description and combo widget are now aligned vertically. > - wrong resize behavior The 'Edit Resource Filter' and 'Add Resource Filter' dialogs now resize properly (at the best of my knowledge). > - "Include Only"/"Exclude All" sounds strange: "Include"/"Exclude" is enough Now changed. > - only some Java developers know the syntax of java.util.regex.Pattern > ==> don't use technical terms in the UI The description now reads instead 'Matches objects based on a regular expression' > - regex pattern field should support content assist > see: org.eclipse.jface.text.FindReplaceDocumentAdapterContentProposalProvider Here, I'm not sure that it makes sense to add support for content assist. First, I'm not aware that any other location in the IDE is actually supporting content assist for regular expressions or string matcher type, what I'm seeing is when a string matcher is allowed in a field, the descriptions mentions something like '* = any string, ? = any character, \ = escape literals: * ? \' (which is what I also put as description for the string matcher. Secondly, I'm not sure what the implementation of a content assist for a string matcher or regular expression field would look like, since the content assist's task is supposed to predict somehow what can be the next character typed, and in those case, any character could follow any other one realistically. Could you be more specific about that, maybe you have a precise idea in mind. Thanks, > - "Arguments:" is wrong. Should be "Pattern:" or "Match string:" Done. > - all option labels must use sentence style Here I assume it is about using upper case for the first letter of the first word only, in that case, I made the required changes. > - icons should be redone by a UI designer > - labels that belong to disabled options must also be disabled Done.
> I'm not aware that any other location in the IDE is actually supporting >content assist for regular expressions Search and Find Replace (Ctrl+F) offer content assist when Regex is selected. I'd expect the same here in case of regex. Also, if possible you should use org.eclipse.jface.text.FindReplaceDocumentAdapter.FindReplaceDocumentAdapter(IDocument) to do the matching. This ensures that the same regex pattern matching is used as in the other places in the IDE and it will match the help given by FindReplaceDocumentAdapterContentProposalProvider.
I submitted a request for icons to our UI designers. They won't be ready by M3. I'll raise a bug for icons to fix when icons are ready.
(In reply to comment #8) > > I'm not aware that any other location in the IDE is actually supporting > >content assist for regular expressions > Search and Find Replace (Ctrl+F) offer content assist when Regex is selected. > I'd expect the same here in case of regex. Also, if possible you should use > org.eclipse.jface.text.FindReplaceDocumentAdapter.FindReplaceDocumentAdapter(IDocument) > to do the matching. This ensures that the same regex pattern matching is used > as in the other places in the IDE and it will match the help given by > FindReplaceDocumentAdapterContentProposalProvider. Ok thanks for the information. With ResourceFilterGroup.java version 1.8, content assist is now supported for regular expression matchers in the dialog. Both code use the java.util.regex specification.
To wrap this thread up, the only issue still pending listed in this bug report is the icon. All other items have been addressed on CVS HEAD
(In reply to comment #11) > To wrap this thread up, the only issue still pending listed in this bug report > is the icon. All other items have been addressed on CVS HEAD I raised bug 292869 for the icons. I hope our designers will redesign them by M4. Other issues are addressed.
There are still no mnemonics for the Type group and 'i' is used twice. Field bug 293553 to track this.
