Bug 292360 - [Memory View] platform renderings do not implement correctly IMemoryRendering#getControl
Summary: [Memory View] platform renderings do not implement correctly IMemoryRendering...
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 3.6   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.6 M3   Edit
Assignee: Samantha Chan CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2009-10-15 05:11 EDT by Teodor Madan CLA
Modified: 2009-10-25 16:37 EDT (History)
0 users

See Also:

Attachments
Proposed fix (884 bytes, patch)
2009-10-15 05:16 EDT, Teodor Madan CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Teodor Madan CLA 2009-10-15 05:11:43 EDT 
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.3) Gecko/20090824 Firefox/3.5.3
Build Identifier: 20090920-1017

Interface specifies that rendering should return the top-control created in
org.eclipse.debug.ui.memory.IMemoryRendering#createControl. 


Reproducible: Always
Comment 1 Teodor Madan CLA 2009-10-15 05:13:26 EDT 
The API mis-implementation affects Bug 290790
Comment 2 Teodor Madan CLA 2009-10-15 05:16:35 EDT 
Created attachment 149620 [details]
Proposed fix

AbstractAsyncTableRendering#createControl creates and returns fPageBook.
Update AbstractAsyncTableRendering#getControl  to return fPageBook as well.
Comment 3 Samantha Chan CLA 2009-10-25 16:00:46 EDT 
Need to review patch
Comment 4 Samantha Chan CLA 2009-10-25 16:37:31 EDT 
Applied patch.
Comment 5 Samantha Chan CLA 2009-10-25 16:37:54 EDT 
verified.