Bug 292198 - [Viewers] Enable optimizations in font support for StyledCellLabelProvider
Summary: [Viewers] Enable optimizations in font support for StyledCellLabelProvider
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 3.7 M5   Edit
Assignee: Markus Keller CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 225351 228376 228397 228695
Blocks: 218605
  Show dependency tree
 
Reported: 2009-10-13 17:17 EDT by Boris Bokowski CLA
Modified: 2011-04-04 19:18 EDT (History)
6 users (show)

See Also:

Attachments
Fix (catch up with bug 228695) (2.71 KB, patch)
2010-06-22 14:05 EDT, Markus Keller CLA 		no flags Details | Diff
Fix 2 (catch up with bug 228376) (2.40 KB, patch)
2011-04-04 14:28 EDT, Markus Keller CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Boris Bokowski CLA 2009-10-13 17:17:20 EDT 
+++ This bug was initially created as a clone of Bug #228397 +++

We could enable optimizations that Martin implemented in one of the patches on bug 228397, since this one was fixed recently:

Bug 228695 Measure event always comes before an Erase/Paint event on Mac and Windows, but not on GTK
https://bugs.eclipse.org/bugs/show_bug.cgi?id=228695
Comment 1 Boris Bokowski CLA 2009-11-26 09:47:29 EST 
Hitesh is now responsible for watching bugs in the [Viewers] component area.
Comment 2 Markus Keller CLA 2010-06-22 14:05:42 EDT 
Created attachment 172445 [details]
Fix (catch up with bug 228695)

Catches up with bug 228695. I tested this on our GTK machine via VNC, but it would be good if someone who really works on Linux could test this too.

The caches in itemOfLastMeasure and elementOfLastMeasure actually cause temporary leaks out in the field. E.g. when you run a JUnit test and then clear the history, the fields still reference the last painted element in the tree, and thereby leak the whole TestRunSession until the next test is started.

After this, the last workaround in StyledCellLabelProvider is for bug 228376.
Comment 3 Markus Keller CLA 2010-06-28 09:56:25 EDT 
Bug 305843 comment 8 confirms that this is fixed under Linux in 3.6, so I've released the fix to HEAD.

Keeping this bug open for bug 228376.
Comment 4 Markus Keller CLA 2011-04-04 14:28:28 EDT 
Created attachment 192492 [details]
Fix 2 (catch up with bug 228376)

Is good on Windows 7, need to test other platforms.
Comment 5 Markus Keller CLA 2011-04-04 19:18:23 EDT 
GTK and Cocoa are also good. Released Fix 2 to HEAD.