Bug 291775 - [formatter] Backport fixes for known issues around 'Never Join Lines' preference to 3.5 maintenance stream
Summary: [formatter] Backport fixes for known issues around 'Never Join Lines' prefere...
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.5   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.5.2   Edit
Assignee: Frederic Fusier CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 281806 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-10-08 11:24 EDT by Frederic Fusier CLA
Modified: 2010-12-27 04:19 EST (History)
3 users (show)

See Also:
daniel_megert: pmc_approved+

Attachments
Proposed patch (66.88 KB, patch)
2010-01-07 07:55 EST, Frederic Fusier CLA 		no flags Details | Diff
Fixed proposed patch (71.57 KB, patch)
2010-01-08 05:17 EST, Frederic Fusier CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Frederic Fusier CLA 2009-10-08 11:24:45 EDT 
So far, there are several known issues around the 'Never Join Lines' preference which are currently fixed in HEAD stream:
 - bug 286601 (3.6M3)
 - bug 279359 (3.6M1)
 - bug 286668 (3.6M2)
 - bug 286912 (3.6M2)
 - bug 287462 (3.6M2)

Bug 283467 is also in this area and has been already backported to 3.5.1. So, I think it would be really a good thing to merge those fixes and backport them to 3.5 maintenance stream.

Note that the fixes for those bugs are in the same area and the merged fix will be smaller than the addition of all of them...
Comment 1 Olivier Thomann CLA 2009-10-08 11:38:50 EDT 
+1. These formatting issues can be very annoying.
Comment 2 Dani Megert CLA 2009-10-13 11:53:29 EDT 
Agree. Please prepare a 3.5.2 patch so that it can be reviewed for 3.5.2.
Comment 3 Olivier Thomann CLA 2010-01-05 11:22:12 EST 
If we cannot extract only changes related to the "Never join lines" issues, we should not release anything for 3.5.2.
We don't want to introduce changes in the formatter unrelated with these issues.
Comment 4 Frederic Fusier CLA 2010-01-07 07:55:43 EST 
Created attachment 155491 [details]
Proposed patch
Comment 5 Frederic Fusier CLA 2010-01-07 11:13:48 EST 
All 'Never join lines' bugs listed in comment 0 are fixed by the proposed patch.
All corresponding tests have been got from HEAD stream and pass with this fix...

So, I think we can release it for 3.5.2
Comment 6 Olivier Thomann CLA 2010-01-07 11:14:44 EST 
+1
Comment 7 Frederic Fusier CLA 2010-01-07 11:22:14 EST 
(In reply to comment #4)
> Created an attachment (id=155491) [details]
> Proposed patch

Released for 3.5.2 in R3_5_maintenance stream.
Comment 8 Frederic Fusier CLA 2010-01-08 05:17:34 EST 
Created attachment 155583 [details]
Fixed proposed patch

For an unknown reason, previous patch didn't contain all intended changes!
This one is correct and it also includes up-to-date copyrights...
Comment 9 Frederic Fusier CLA 2010-01-08 05:21:56 EST 
(In reply to comment #8)
> Created an attachment (id=155583) [details]
> Fixed proposed patch
> 
> For an unknown reason, previous patch didn't contain all intended changes!
> This one is correct and it also includes up-to-date copyrights...

I forgot to mention that the problem was only in the attached patch. The code released yesterday in the R3_5_maintenance stream was correct. I only forgot to update the copyrights but it's fixed now...
Comment 10 Olivier Thomann CLA 2010-01-22 13:21:07 EST 
Verified for 3.5.2RC2 using M20100120-0800.
Comment 11 Frederic Fusier CLA 2010-12-27 04:19:49 EST 
*** Bug 281806 has been marked as a duplicate of this bug. ***