Community
Participate
Working Groups
Build ID: 20090621-0832 Steps To Reproduce: 1. Enable "Never Join Lines" on source code for the java formatter. 2. Attempt to format the following code. Note the @@\n@@ below should be replaced with a newline after pasting. StringBuilder builder = new StringBuilder(); builder.append("abc").append("def").append("ghi").append("jkl").append("mno")@@\n@@.append("pqr").append("stu").append("vwx").append("yz"); 3. The previous string of appends should fall on two lines. "abc" through "mno" are on one line, the next line starts with ".append". 4. Format the code. 5. Note how eclipse incorrectly places all of the code on a single line. 6. Change the code to: builder.append("abc").append("def").append("ghi").append("jkl").append(@@\n@@"mno").append("pqr").append("stu").append("vwx").append("yz"); 7. The code should still be on two lines, but is split after a ".append(". 8. Format the code. 9. Note how the code correctly stays on two lines. More information:
I have some problems with your scenario. Using Eclipse built-in profile, I cannot reproduce step 5 (i.e. on a single line), I always get 3 lines: >> >> builder.append("abc").append("def").append("ghi").append("jkl").append( >> >> >> >> "mno") >> >> >> >> .append("pqr").append("stu").append("vwx").append("yz"); (where '>> ' shows a tabulation) Do you modify the default Eclipse built-in profile? I also see on step 9 that the second line is indented: >> >> builder.append("abc").append("def").append("ghi").append("jkl").append( >> >> >> >> "mno").append("pqr").append("stu").append("vwx").append("yz"); although it should not: >> >> builder.append("abc").append("def").append("ghi").append("jkl").append( >> >> "mno").append("pqr").append("stu").append("vwx").append("yz"); So, I definitely agrees that there's a real issue... I just need a clear test case to highlight it. Here's my proposal using '>> ' as a tabulation: public class Test { >> void foo() { >> >> StringBuilder builder = new StringBuilder(); >> >> builder.append("abc").append("def") >> >> .append("ghi").append("jkl").append("mno") >> >> .append("pqr").append("stu").append("vwx").append("yz"); >> } } Currently, using Eclipse built-in profile + 'Never join lines'=true + 'Maximum Line width'=40, the test case above is formatted as follow: public class Test { >> void foo() { >> >> StringBuilder builder = new StringBuilder(); >> >> builder.append("abc").append( >> >> >> >> "def") >> >> >> >> .append("ghi").append( >> >> >> >> "jkl").append("mno") >> >> >> >> .append("pqr").append( >> >> >> >> "stu").append("vwx") >> >> >> >> .append("yz"); >> } } Instead we should have: public class Test { >> void foo() { >> >> StringBuilder builder = new StringBuilder(); >> >> builder.append("abc").append( >> >> >> >> "def") >> >> .append("ghi").append("jkl") >> >> >> >> .append("mno") >> >> .append("pqr").append("stu") >> >> >> >> .append("vwx").append( >> >> >> >> >> >> "yz"); >> } }
Another variation which may be more convincing... Here's the test case: public class Test { >> void foo() { >> >> StringBuilder builder = new StringBuilder(); >> >> builder.append("abc").append("def") >> >> .append("ghi").append("jkl").append("mno") >> >> .append("pqr").append("stu").append("vwx") >> >> .append("yz"); >> } } Currently, using Eclipse built-in profile + 'Never join lines'=true + 'Maximum Line width'=60, the test case above is formatted as follow: public class Test { >> void foo() { >> >> StringBuilder builder = new StringBuilder(); >> >> builder.append("abc").append("def") >> >> >> >> .append("ghi").append("jkl").append("mno") >> >> >> >> .append("pqr").append("stu").append("vwx") >> >> >> >> .append("yz"); >> } } although it should be unchanged...
I forgot to mention that I have the line length set to something exorbitantly high, like 200 characters. That is probably why you are seeing three lines instead of the two.
(In reply to comment #3) > I forgot to mention that I have the line length set to something exorbitantly > high, like 200 characters. That is probably why you are seeing three lines > instead of the two. > This was my assumption, thanks to confirm it.
This bug will be fixed by the patch of bug 286912: https://bugs.eclipse.org/bugs/attachment.cgi?id=144846
Released for 3.6M2 in HEAD stream.
Verified for 3.6M2 using I20090914-1800
Verified.
