Bug 291519 - Enable the jpa criteriaAPI tests on the server
Summary: Enable the jpa criteriaAPI tests on the server
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Eclipselink (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: test
Depends on:
Blocks:
 
Reported: 2009-10-06 14:09 EDT by Feng Yu CLA
Modified: 2022-06-09 10:06 EDT (History)
2 users (show)

See Also:

Attachments
bug291519 fix patch (65.57 KB, application/octet-stream)
2009-10-06 14:44 EDT, Feng Yu CLA 		peter.krogh: iplog+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Feng Yu CLA 2009-10-06 14:09:08 EDT 
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.2) Gecko/20090729 Firefox/3.5.2 (.NET CLR 3.5.30729)
Build Identifier: 5452

Enable two test suites: AdvancedCriteriaQueryTestSuite and JUnitCriteriaUnitTestSuite, which is included in the jpa lrg, run on the server

Reproducible: Always
Comment 1 Feng Yu CLA 2009-10-06 14:44:09 EDT 
Created attachment 148926 [details]
bug291519 fix patch
Comment 2 Feng Yu CLA 2009-10-06 14:45:50 EDT 
1. Modified the AdvancedCriteriaQueryTestSuite.java and JUnitCriteriaUnitTestSuite.java so they can be ran in the container. I tested on WLS 10.3.1 + manually adding javax.persistence_2.0_preview.jar in the classpath.

2. Add CriteriaServerTestSuite.java

3. Add target server-test-criteria in the eclipselink.jpa.test/build.xml
Comment 3 Michael OBrien CLA 2009-10-07 08:42:08 EDT 
Kevin,
    The change made to link the modelgen tests to the jpa test suite is missing the eclipse project side of the change.
    A reference must be made in eclipse in the jpa test projet to the modelgen project in order to compile properly.

    http://fisheye2.atlassian.com/changelog/eclipselink/?cs=5463

    fix: Add this to eclipselink.jpa.test/.classpath
<classpathentry combineaccessrules="false" kind="src" path="/eclipselink.jpa.modelgen.test"/>
 

    I didn't pick up this failure earlier because it does not appear in the package viewer.
    I'd make the simple change myself but a ant/eclipse compilation and ant or eclipse regression should be run.

    The ant build is fine - If changes are made to projects in ant (build.xml) - the same changes must be made in eclipse (.project/.classpath).

    thank you
    /michael
Comment 4 Michael OBrien CLA 2009-10-07 08:45:56 EDT 
Actually you will need more than this fix - a cycle will exist between the 2 projects
Comment 5 Feng Yu CLA 2009-10-09 15:20:24 EDT 
Guy (gpelletie) fixed the project dependency with his txn, which was checked in the revision: 5493.
Comment 6 Eclipse Webmaster CLA 2022-06-09 10:06:02 EDT 
The Eclipselink project has moved to Github: https://github.com/eclipse-ee4j/eclipselink