Bug 290821 - [WorkbenchParts] org.eclipse.ui.internal.partSite javadoc incorrect
Summary: [WorkbenchParts] org.eclipse.ui.internal.partSite javadoc incorrect
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows XP
: P3 normal with 1 vote (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-29 12:25 EDT by Daniel U. Thibault CLA
Modified: 2019-09-06 16:11 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel U. Thibault CLA 2009-09-29 12:25:09 EDT
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.9.1.3) Gecko/20090824 Firefox/3.5.3
Build Identifier: 3.5.0

The org.eclipse.ui.internal.PartSite javadoc reads, in its header:

"The <code>PartSite</code> lifecycle is as follows ..
 * 
 * <ol>
 * <li>a site is constructed </li>
 * <li>a part is constructed and stored in the part </li>
 * <li>the site calls part.init() </li>
 * <li>a pane is constructed and stored in the site </li>
 * <li>the action bars for a part are constructed and stored in the site </li>
 * <li>the pane is added to a presentation </li>
 * <li>the SWT widgets for the pane and part are created </li>
 * <li>the site is activated, causing the actions to become visible </li>
 * </ol>"

Examination of the current code (specifically org.eclipse.ui.internal.EditorReference.createPartHelper) shows the life cycle is actually:

"The <code>PartSite</code> lifecycle is as follows:
 * <ol>
 * <li>a part is constructed, instantiating the implementing class</li>
 * <li>a pane is constructed and linked to the part</li>
 * <li>the pane SWT control is created</li>
 * <li>a site is constructed and linked to the part</li>
 * <li>the action bars for the part are constructed and stored in the site</li>
 * <li>the site calls part.init</li>
 * <li>if applicable, IPersistableEditor.restoreState is called on the part</li>
 * <li>the part SWT contents are created and laid out</li>
 * <li>PartTester.testEditor is called on the part</li>
 * </ol>"


Reproducible: Always
Comment 1 Eclipse Webmaster CLA 2019-09-06 16:11:31 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.