Bug 290812 - provide UI for setting comment visibility
Summary: provide UI for setting comment visibility
Status: RESOLVED NOT_ECLIPSE
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P2 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Mylyn Inbox CLA
QA Contact:
URL: https://studio.atlassian.com/browse/P...
Whiteboard:
Keywords:
Depends on: 211654
Blocks:
  Show dependency tree
 
Reported: 2009-09-29 11:03 EDT by Steffen Pingel CLA
Modified: 2010-02-27 20:18 EST (History)
3 users (show)

See Also:

Attachments
jira_comment_visibility_ui (4.61 KB, patch)
2009-09-30 05:03 EDT, Jacek Jaroczynski CLA 		no flags Details | Diff
jira_comment_visibility_ui (4.66 KB, patch)
2009-09-30 06:29 EDT, Jacek Jaroczynski CLA 		no flags Details | Diff
jira_comment_visibility_ui (4.70 KB, patch)
2009-09-30 10:48 EDT, Jacek Jaroczynski CLA 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Steffen Pingel CLA 2009-09-29 11:03:16 EDT 
The task editor should provide a way to contribute controls to the new comment section to control the visibility of comments.
Comment 1 Jacek Jaroczynski CLA 2009-09-30 05:03:28 EDT 
Created attachment 148398 [details]
jira_comment_visibility_ui

ui patch attached
Comment 2 Jacek Jaroczynski CLA 2009-09-30 06:29:51 EDT 
Created attachment 148405 [details]
jira_comment_visibility_ui

ui patch improvement
Comment 3 Jacek Jaroczynski CLA 2009-09-30 10:48:10 EDT 
Created attachment 148432 [details]
jira_comment_visibility_ui

next improvement :) (painting border for project role combo)
Comment 4 Steffen Pingel CLA 2009-09-30 15:40:53 EDT 
That's a good start. I would prefer to not introduce new API for this. You should be able to remove the existing comment part in JiraTaskEditorPage.createPartDescriptors() and replace it with your own descriptor that constructs the custom new comment editor. Please rename TaskEditorNewCommentPartJira to JiraNewCommentPart to follow the naming conventions of other classes.

It would be great if you could add a few test cases, particularly for getting project roles and posting comments with a visibility level as an unprivileged user. Let me know if you need any additional setup on the test repositories for that.
Comment 5 Steffen Pingel CLA 2009-11-16 13:27:47 EST 
Jacek, are you planning to reiterate over the patch and address the points raised in comment 4?
Comment 6 Jacek Jaroczynski CLA 2009-12-15 06:44:48 EST 
I'm sorry I missed your question. We can return to the problem when JIRA connector is already forked which is planed to be done in January.
Comment 7 Steffen Pingel CLA 2010-02-27 20:18:23 EST 
The Mylyn JIRA Connector has moved to Atlassian. All unresolved Mylyn bugs assigned to the JIRA component, which includes this bug, have been copied to https://studio.atlassian.com/browse/PLE and marked as resolved on bugs.eclipse.org. The new location of this bug report can be found in the URL field. 

Please see this FAQ entry for further details: http://wiki.eclipse.org/Mylyn/FAQ#What_happened_to_the_Mylyn_JIRA_Connector.3F .