Community
Participate
Working Groups
Created attachment 148172 [details] compare example. When using the compare editor on the mac the decorators (not sure on the term) do not seem to match the location of the changes in the file. I think this is because the scroll arrows at the bottom give you less area to work with for the decorators. Actually, this seems to be a general issue with decorating the editor scroll bar on the Mac. Any warnings and errors in the java editor give me the same results. The longer the file the more evident the issue becomes at the bottom of the file. I hope this description makes some sense. Let me know if you need some more information.
Is this Mac or Carbon? Or both?
I'm running on Cocoa build.
This is well known, and I believe Text would need new API from SWT to be able to fix this. If you want this to be "less wrong", you can change your system preferences to place the scroll arrows at the top and bottom (under "Appearance").
Thanks Boris. I did not know you could change that (shows my newbie Mac ignorance) :)
>I believe Text would need new API from SWT to be able to fix this. See bug 40258.
Created attachment 151493 [details] first stab First stab at a fix for text editors. Looks good on Cocoa with all 4 arrow placement variants: 2 from System Preferences + 2 hidden options (use TinkerTool et al.). Need to test on other platforms. Compare editor will need similar changes in TextMergeViewer.
Created attachment 151546 [details] patch 2 Some tuning. Verified on WinXP.
Released to HEAD. Filed bug 294454 to do the same changes in Compare.
(In reply to comment #7) > Created an attachment (id=151546) [details] > patch 2 > > Some tuning. Verified on WinXP. So this is a general issue, not just for Mac? Is it not as noticeable on windows because the scroll arrows are on top and bottom by default?
> So this is a general issue, not just for Mac? Is it not as noticeable on > windows because the scroll arrows are on top and bottom by default? Yes. Up to now, the assumption was that a scrollbar has an arrow on top and an arrow at the bottom, and the arrow buttons are rectangular (same height as scrollbar width). That assumption is correct for WinXP, but was wrong for certain GTK themes (where arrow buttons don't have to be rectangular), and especially wrong on the Mac with both arrows at the end. The tuning in patch 2 was not a special thing for WinXP but a general glitch in a corner case (when the editor is very small).
Additional complication: The Mac hides the thumb and the arrows when the scrollbar is too short and when there's nothing to scroll. Fixed in HEAD by adding a cache for arrow heights and special computation when scroll bar is too short.
Marking as fixed.
