Bug 290549 - Scheduling rule for IResource#setDerived(boolean, IProgressMonitor)
Summary: Scheduling rule for IResource#setDerived(boolean, IProgressMonitor)
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Resources (show other bugs)
Version: 3.6   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.6 M3   Edit
Assignee: Pawel Pogorzelski CLA
QA Contact:
URL:
Whiteboard:
Keywords: api
Depends on: 45805
Blocks:
  Show dependency tree
 
Reported: 2009-09-25 10:20 EDT by Markus Keller CLA
Modified: 2009-10-09 12:34 EDT (History)
1 user (show)

See Also:

Attachments
Patch_v01 (6.82 KB, patch)
2009-10-06 08:49 EDT, Pawel Pogorzelski CLA 		no flags Details | Diff
Patch_v02 (7.27 KB, patch)
2009-10-09 08:56 EDT, Pawel Pogorzelski CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2009-09-25 10:20:04 EDT 
HEAD

The Javadoc of IResource#setDerived(boolean, IProgressMonitor) should specify the required scheduling rule like other methods on IResource taking a progress monitor.

This probably also means adding a new method in the IResourceRuleFactory (like there was a new charsetRule(IResource)).
Comment 1 Markus Keller CLA 2009-10-02 11:14:43 EDT 
IResourceDelta#getFlags() also needs to describe IResourceDelta#DERIVED_CHANGED in prose and as an @see tag.

An while you're at it, please also add
 * @see IResourceDelta#LOCAL_CHANGED
 * @see IResourceDelta#COPIED_FROM
and the missing description of the COPIED_FROM constant.
Comment 2 Szymon Brandys CLA 2009-10-02 11:23:42 EDT 
This is something we can do even earlier.
Comment 3 Markus Keller CLA 2009-10-05 08:50:58 EDT 
> This is something we can do even earlier.

I just wanted to make sure is is done before the API freeze. Actually, is should be done right now (for M3), since the new API is incomplete and adopters can only use it when it is complete.
Comment 4 Pawel Pogorzelski CLA 2009-10-06 08:49:53 EDT 
Created attachment 148876 [details]
Patch_v01

Szymon, please have a look.
Comment 5 Pawel Pogorzelski CLA 2009-10-09 08:56:34 EDT 
Created attachment 149230 [details]
Patch_v02

Patch update.
Comment 6 Szymon Brandys CLA 2009-10-09 12:34:09 EDT 
Released to HEAD with some minor changes in the javadoc.