Bug 289385 - Investigate comment in performance tests
Summary: Investigate comment in performance tests
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.6 M3   Edit
Assignee: Satyam Kandula CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-14 14:36 EDT by Olivier Thomann CLA
Modified: 2009-10-26 11:19 EDT (History)
1 user (show)

See Also:

Attachments
Patch (2.07 KB, patch)
2009-10-22 08:28 EDT, Satyam Kandula CLA 		frederic_fusier: iplog+
frederic_fusier: review+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Thomann CLA 2009-09-14 14:36:17 EDT 
The following two tests should be analyzed to see if the comments are still required in 3.6 streams.

From bug 288148 comment 1:
Note that there's also two other commented tests in:
 - FullSourceWorkspaceModelTests.testSeekPackageFragments()
 - FullSourceWorkspaceSearchTests.testSearchMethod()

But these comments say that there's a problem of stability, I guess they may be
still accurate and so cannot be removed until more investigation is done...
Comment 1 Olivier Thomann CLA 2009-10-21 13:13:15 EDT 
Satyam, please investigate for M3.
Comment 2 Satyam Kandula CLA 2009-10-22 08:28:00 EDT 
Created attachment 150229 [details]
Patch

Both these tests look to be stable now and hence removed the comment. 
Olivier/Frederic, Please deliver this patch.
Comment 3 Frederic Fusier CLA 2009-10-22 08:51:41 EDT 
Comment on attachment 150229 [details]
Patch

I also agree that these seem to be stabilized now. Of course, some outliers happened but not more frequently than the other non-commented tests.

Hence, the patch looks good to me...
Comment 4 Frederic Fusier CLA 2009-10-22 08:57:52 EDT 
(In reply to comment #2)
> Created an attachment (id=150229) [details]
> Patch
> 
Satyam's patch released for 3.6M3 in HEAD stream
Comment 5 Frederic Fusier CLA 2009-10-26 11:19:25 EDT 
Verified for 3.6M3 using build I20091026-2000