Bug 288148 - [perfs] Comments applied for performance tests may be obsolete
Summary: [perfs] Comments applied for performance tests may be obsolete
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.6   Edit
Hardware: PC Windows Vista
: P3 normal (vote)
Target Milestone: 3.6 M2   Edit
Assignee: Olivier Thomann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 288122
  Show dependency tree
 
Reported: 2009-08-31 11:58 EDT by Frederic Fusier CLA
Modified: 2010-05-21 06:59 EDT (History)
1 user (show)

See Also:

Attachments
Proposed fix (2.29 KB, patch)
2009-09-14 14:40 EDT, Olivier Thomann CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Frederic Fusier CLA 2009-08-31 11:58:45 EDT 
Looking at code in HEAD today, I can see several performance tests referencing
the Performance.setComment(...) method:

1) FullSourceWorkspaceModelTests.testInitJDTPlugin():

The comment says:
"Added clean-up of internal thread local which imply additional garbage collect during the restart. It concerns only the performance test itself and has no impact in standard Eclipse usage..."

I think this comment should be removed for 3.6 performance tests it refers to a change done between 3.4 and 3.5.


2) FullSourceWorkspaceCompletionTests.testPerfCompleteMemberAccess():

The comment says:
"Regression introduced to fix bug 250454"

As bug 250454 has been fixed in 3.5, the regression should no longer appear in 3.6 performance tests, hence this comment should be removed.
Comment 1 Frederic Fusier CLA 2009-08-31 11:59:03 EDT 
Note that there's also two other commented tests in:
 - FullSourceWorkspaceModelTests.testSeekPackageFragments()
 - FullSourceWorkspaceSearchTests.testSearchMethod()

But these comments say that there's a problem of stability, I guess they may be still accurate and so cannot be removed until more investigation is done...
Comment 2 Olivier Thomann CLA 2009-09-14 14:38:08 EDT 
I entered bug 289385 to take care of the comment 1.
Removed the comments reported in comment 0.
Comment 3 Olivier Thomann CLA 2009-09-14 14:40:00 EDT 
Created attachment 147128 [details]
Proposed fix
Comment 4 Kent Johnson CLA 2009-09-15 11:43:52 EDT 
Verified for 3.6M2