Community
Participate
Working Groups
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.2) Gecko/20090729 Firefox/3.5.2 (.NET CLR 3.5.30729) Build Identifier: M20090807-0800 Properties Dialog change his size automatically and is a little smaller by default PropertyDialog has a minimum page size of 400x400 a bigger minimum size would be useful for complex/bigger settings pages Reproducible: Always Steps to Reproduce: 1. start eclipse with a new cleaned workspace 2. in package explorer of java perspective create a java project (right click -> new -> Java Project named p1 3. create a second Java Project named p2 4. click on p1 and press Alt+Enter to open Properties for p1 5. select Builders on left tree then closing the dialog by pressing Cancel 6. click on p2 and press Alt+Enter to open Properties for p2 7. you see that the dialog has a smaller horizontal size
Created attachment 146491 [details] proposed patch fix the smaller horizontal size when reopening Properties set the minimum page size to 480 x 480 (before was 400 x 400) bigger size cause minor problem, for example, to https://bugs.eclipse.org/bugs/show_bug.cgi?id=272912
Gaetano, thanks for the patch!! We love it when folks take the time to do this. After looking I'm not even sure if this is a defect. Here's what's happening: When it opens it's in the preferred size for the selected entry When another entry is selected it will *grow* if necessary but never shrink (to avoid continual flicker) So, on the first open the 'Resource' item is selected so the dialog is sized for its properties. Selecting 'Builders' doesn't shrink it even though it doesn't need the space. When you re-open it the default size is re-calculated so now it picks up the smaller size from the 'Builders' page and gives teh effect you report. Note that if you re-select 'Resource' then it grows back to its 'original' size. I can't think of a way to make this flow better. If we cached the size then it would eventually always be the size of the *largest* page you've ever looked at and the continual sizing (growing/shrinking to exactly fit each page) would 'fix' this issue but we think that this would be less usable than the current solution. BTW, for the same reasons changing the default won't really help too much because it's guaranteed to be large enough on opening to show the selected page (usually larger than 400 anyways...;-).
(In reply to comment #2) > Gaetano, thanks for the patch!! We love it when folks take the time to do this. Hi, thanks for the long and detailed answer > > After looking I'm not even sure if this is a defect. Here's what's happening: > > When it opens it's in the preferred size for the selected entry > When another entry is selected it will *grow* if necessary but never shrink (to > avoid continual flicker) I agree but I like to have preferred size >= minimumPageSize and also, that if the user resize to a smaller/big size when re-open the page the user size is used > > So, on the first open the 'Resource' item is selected so the dialog is sized > for its properties. Selecting 'Builders' doesn't shrink it even though it > doesn't need the space. When you re-open it the default size is re-calculated > so now it picks up the smaller size from the 'Builders' page and gives teh > effect you report. > > Note that if you re-select 'Resource' then it grows back to its 'original' > size. I can't think of a way to make this flow better. If we cached the size > then it would eventually always be the size of the *largest* page you've ever > looked at and the continual sizing (growing/shrinking to exactly fit each page) > would 'fix' this issue but we think that this would be less usable than the > current solution. > > BTW, for the same reasons changing the default won't really help too much > because it's guaranteed to be large enough on opening to show the selected page > (usually larger than 400 anyways...;-). current solution is good, but there are some CDT page that need a bigger size simply changing the minimum page size help a lot and all your discussion remain valid anyway, you have two choice :) 1) modify minimum page size 2) see bug/enhancement #288648 #232296 #272912 (Show dependency tree) , your help/feedback will be much appreciated Thanks, Gaetano
Gaetano, I think that all you should need to do in this case is to have the CDT pages implement 'IPreferencePage#computeSize' and return the desired size (this is what the 'Resources' page does to grow the area when you switch back to it).
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.
