Community
Participate
Working Groups
Fix For and Affects should list only versions that current issue is associated with. If user wants to modify versions open a dialog box with full list of versions (or show it by other means). Do the same for Components.
Created attachment 145793 [details] Fix for this Here's a fix for this enhancement.
Interesting suggestions. It is much more readable, especially for repositories with a lot of versions. And it makes better use of the horizontal space. However it seems to somewhat break with the UI look of the section. The missing borders for an editable field, are (especially if those entries take multiple lines) a bit weird (not sure how it would look with border though, especially since it is non editable). The pencil seems to not fit in the whole look, but that may just be my personal preference. The pencil should however be vertically centered like the label, not stick to the bottom. Overall, if few versions are selected, it is much more readable. But if a lot of versions are selected, it gets harder (since every version has a different width). The additional dialog might also be considered a regression (since it is not possible to select a version with a single click) - especially in a new (unsubmitted) task this is an issue I would say. Allmost all my negative points seem to be personal look and feel preferences though, so I think that should be a discussion among more people. I wonder if, for the sake of quickly seeing what the selected versions are, a tooltip showing that comma separated list, appearing on hover over the existing table would be enough?
Well, fixing borders is one line of code. Pencil is at the bottom because I prefer it that way, that's also easy to fix. I don't think adding a tooltip would be a solution here - users would not know that they have it there. I think that more important here is to have an easily readable form. List was unreadable. That fixes it.
Created attachment 145847 [details] screenshot
That looks good Pawel. I am unsure about the border. It looks cleaner without it and the pencil should be sufficient to indicate that it's editable. I have added it to the agenda for the next Mylyn meeting to discuss and review the UI. It could make sense to use that same UI for other connectors as well: http://wiki.eclipse.org/Mylyn_Meetings#Next_Meeting. I noticed a few minor problems when I tested the patch: * The font is not set to the task editor font. * Incoming changes are not properly indicated. The blue background should be applied to the whole control (marked in read in the screenshot). Shawn is currently working on generalizing the keyword selection dialog which has an almost identical UI. I would suggest to wait until bug 279334 is resolved then we can reuse the same code for JIRA and fix up the remaining nits.
Pawel, can you refactor the patch to make use of CheckBoxTreeDialog and CheckBoxMultiSelectAttribiteEditor which Shawn added as part of bug 287899? On a side note, it seems a bit heavy weight to use a RichTextEditor control since neither hyperlinking nor context assist are needed for the version or component selection. Have you considered using a simple Text control instead?
Sure, I can refactor it. Yes, I did thought about using simpler widget but decided to use RTE as sooner or later will add there hyperlink support.
> Yes, I did thought about using simpler widget but decided to use RTE as sooner > or later will add there hyperlink support. Can you elaborate on the the purpose of the hyperlinking? An RTE is fairly expensive in terms of resources and the hyperlinking support comes with some complexity such as registering a detector. I would consider a more lightweight widget such as Text or Link if clicking components only triggers the selection dialog but does not require extensibility or separate actions for each component.
Created attachment 145917 [details] Improved patch Thanks Steffen for pointing out that Shawn implemented this widget idea into commons. That's great news as this kind of a widget would be usefull in other places. I'm attaching a newer version using CheckBoxMultiSelectAttributeEditor. One thing though - I modified CBMSAE to support two important things: - if user clicks Edit, then OK in the dialog box but doesn't change the task editor will stay in unmodified state (I compare new values to the old ones), originally the editor pointed out changes but it shouldn't in my opionion as nothing was changed - also if user selects a lot of options text will be cut off (check the screenshot I'll attach), that's unacceptable in my opinion - I added a hack to resize the text widget and the whole section. please implement a proper way to do it that can be re-used in other AttributeEditors
Created attachment 145918 [details] Too long text is cut off Check text near Edit button. The widget should not cut off it there. Please provide a proper way to resize sections when content is changed.
Created attachment 146889 [details] sample of 'due date' picker on a mac
Created attachment 146890 [details] sample date picker on ical
Created attachment 147003 [details] updated patch
Created attachment 147004 [details] mylyn/context/zip
Created attachment 147006 [details] screenshot
Thanks Pawel. I have added a call to reflow the form when the size of the text field changes. This is necessary to properly update the scroll bars of the form. There is some potential for improving the edit UI, e.g. by using a tooltip-like shell without a title for selecting items instead of the modal dialog. We could also consider replacing the Edit button by an icon that only shows on hover. Most JIRA editors will have three additional buttons now for Affects Versions, Fix Versions and Components which I find looks a bit cluttered.
I've tested out the latest changes, and they're excellent. It's much easier to see what's selected when there's a long list of items. Also the presentation is more compact. Any chance of having a 'clear' button in the pop-up dialog that deselects all items? When there are many items (eg: 100's) it's a pain to have to scroll through them all to deselect one or two items.
Thanks for the feedback David. Good idea to add a clear button. I have added a comment to bug 286286 which has discussion to address remaining nits in the scheduled date picker which shares the implementation.
Created attachment 148037 [details] new screenshot with inplace dialog
Good stuff. Thanks for the attachments David. Here's the UI review feedback from the Mylyn call, Steffen can elaborate: * Make the keyword a border-less shell (similar to an InfoPopupDialog) and have it appear below the Edit button. * Retain the current layout, including the filter text box. * Retain the OK/Cancel buttons for now, we could consider getting rid of them later.
Not sure how the dev process looks like here, but wasn't this issue marked as resolved some time ago, and there are still new ideas and requirements (which is great) coming here? Shouldn't they land at a different issue (like bug 286286) or cause this issue to be reopened? Are the last Mik's suggestion reflected anywhere, but this resolved issue? Just let me know, as I would like understand better how we are suppose to track such stuff on bugzilla here.
The recent comments were added as part of a UI review that we held on today's Mylyn call. The usual process is to reopen a bug when additional work needs to be done but in this case we will be tracking that on bug 286286 since the implementations overlap. Please feel free to add your thoughts on bug 286286 if you want to chime in.
Thanks Steffen. Now it's clear.
