Comment 1 Francis Upton IV 2009-08-17 05:03:26 EDT

This is very likely fixed in 3.5.  Can you review the list of bugs in the link below [1] and see if one of them matches what you are reporting?  Alternatively, can you try your scenario in 3.5?

[1] https://bugs.eclipse.org/bugs/buglist.cgi?query_format=advanced&short_desc_type=allwordssubstr&short_desc=CommonNavigator&classification=Eclipse&product=Platform&component=UI&target_milestone=3.5&target_milestone=3.5+M1&target_milestone=3.5+M2&target_milestone=3.5+M3&target_milestone=3.5+M4&target_milestone=3.5+M5&target_milestone=3.5+M6&target_milestone=3.5+M7&target_milestone=3.5+RC1&target_milestone=3.5+RC2&target_milestone=3.5+RC3&target_milestone=3.5+RC4&long_desc_type=allwordssubstr&long_desc=&bug_file_loc_type=allwordssubstr&bug_file_loc=&status_whiteboard_type=allwordssubstr&status_whiteboard=dnd&keywords_type=allwords&keywords=&bug_status=RESOLVED&resolution=FIXED&emailtype1=substring&email1=&emailtype2=substring&email2=&bugidtype=include&bug_id=&votes=&chfieldfrom=&chfieldto=Now&chfieldvalue=&cmdtype=doit&order=Reuse+same+sort+as+last+time&field0-0-0=noop&type0-0-0=noop&value0-0-0=

Comment 2 saurav sarkar 2009-08-17 06:19:08 EDT

(In reply to comment #1)
> This is very likely fixed in 3.5.  Can you review the list of bugs in the link
> below [1] and see if one of them matches what you are reporting? 
> Alternatively, can you try your scenario in 3.5?
> [1]
> https://bugs.eclipse.org/bugs/buglist.cgi?query_format=advanced&short_desc_type=allwordssubstr&short_desc=CommonNavigator&classification=Eclipse&product=Platform&component=UI&target_milestone=3.5&target_milestone=3.5+M1&target_milestone=3.5+M2&target_milestone=3.5+M3&target_milestone=3.5+M4&target_milestone=3.5+M5&target_milestone=3.5+M6&target_milestone=3.5+M7&target_milestone=3.5+RC1&target_milestone=3.5+RC2&target_milestone=3.5+RC3&target_milestone=3.5+RC4&long_desc_type=allwordssubstr&long_desc=&bug_file_loc_type=allwordssubstr&bug_file_loc=&status_whiteboard_type=allwordssubstr&status_whiteboard=dnd&keywords_type=allwords&keywords=&bug_status=RESOLVED&resolution=FIXED&emailtype1=substring&email1=&emailtype2=substring&email2=&bugidtype=include&bug_id=&votes=&chfieldfrom=&chfieldto=Now&chfieldvalue=&cmdtype=doit&order=Reuse+same+sort+as+last+time&field0-0-0=noop&type0-0-0=noop&value0-0-0=

Hi Francis,

Thanks for the comments.Unfortunately i am not able to test in 3.5 as our productized IDE has not still migrated to 3.5.But i do not the see this bug being reported before.Could you please confirm or let me know if i need to provide any further details.

Best Regards,
Saurav

Comment 3 Francis Upton IV 2009-08-17 10:20:36 EDT

(In reply to comment #2)
Unfortunately i am not able to test in 3.5 as our
> productized IDE has not still migrated to 3.5.

You are aware I hope that even if this is a bug in 3.5 (or 3.6) there are no further releases of 3.4.x, a fix will be provided only in 3.6 (and possibly 3.5.1 or 2).

Comment 4 Francis Upton IV 2009-08-20 01:19:34 EDT

Make sure you return "true" from setDragData() if you are setting event.doIt to false, this should cancel the drag.  If you are returning false from setDragData() it will continue looking for another way to set the data, which is probably not what you want.

I'm going to close this; if my suggestion does not fix your problem, please reopen this, and please provide your CommonDragAdapterAssistant subclass.

Comment 5 saurav sarkar 2009-08-25 01:11:19 EDT

(In reply to comment #4)
> Make sure you return "true" from setDragData() if you are setting event.doIt to
> false, this should cancel the drag.  If you are returning false from
> setDragData() it will continue looking for another way to set the data, which
> is probably not what you want.
> I'm going to close this; if my suggestion does not fix your problem, please
> reopen this, and please provide your CommonDragAdapterAssistant subclass.

I tried everything it did not work.

Below is the Code from the CommonDragAdapter


[code]

if(assistants[i].setDragData(event,
									(IStructuredSelection) selection)) {
								return;
							}
						} catch (RuntimeException re) {
							NavigatorPlugin.logError(0, re.getMessage(), re);
						}
					}

				}
			}

			event.doit = false;
[/code]

My case it returns false so it sets event.doit=false;

there is no checkingfor event.doit done in CNF acc. to me
which is done in DelegatingDragAdpater in normal JFace viewer.
I am not very sure so could you please provide your inputs on this.
So reopening the bug.

cheers,
Saurav

Comment 6 Francis Upton IV 2009-08-25 01:23:41 EDT

(In reply to comment #5)

> 
> My case it returns false so it sets event.doit=false;
Your implementation of the method setDragData() should return true if you want to have event.doit used.  If you return false from setDragData() whatever you set event.doit to will be ignored. 

> 
> there is no checkingfor event.doit done in CNF acc. to me
Look at the CommonDragAdapter.dragSetData() where it calls setDragData(), note that it returns if you return true, and if you have set event.doit to false, then that should apply.

Again, I'm closing.  If you are still having trouble please reopen and please provide your complete implementation of your CommonDragAdaptorAssistant subclass (you did not provide that as far as I can see).

Comment 7 saurav sarkar 2009-08-25 01:53:30 EDT

Created attachment 145511 [details]
Implementaion fo CommonDragAdapter

Comment 8 saurav sarkar 2009-08-25 01:55:06 EDT

(In reply to comment #6)
> (In reply to comment #5)
> > 
> > My case it returns false so it sets event.doit=false;
> Your implementation of the method setDragData() should return true if you want
> to have event.doit used.  If you return false from setDragData() whatever you
> set event.doit to will be ignored. 
> > 
> > there is no checkingfor event.doit done in CNF acc. to me
> Look at the CommonDragAdapter.dragSetData() where it calls setDragData(), note
> that it returns if you return true, and if you have set event.doit to false,
> then that should apply.
> Again, I'm closing.  If you are still having trouble please reopen and please
> provide your complete implementation of your CommonDragAdaptorAssistant
> subclass (you did not provide that as far as I can see).

In the attachement you could find the condition having the comments.
I returned true as well as have set the event.doit=false.But still getting the same error.Any other variable of the event object i need to set?

Comment 9 Francis Upton IV 2009-08-25 02:09:51 EDT

Ok, now I'm remembering this.  The problem is that event.doit has no effect on a setDragData call.  Once you have agreed to start the drag, it must finish.  You can't cancel it at setDragData time.  See SWT DragSourceEvent (the description of the doit flag).  Also see the SWT DragSourceListener.

I'm remembering in 3.5 we had some conversations with the SWT about doing someting about this because sometimes it's desirable to be able to cancel the drag if you don't like the data that you have, but I have been unable to find any of the bug reports that touched this area.

I'm going to transfer this to SWT for comment to see if they remember anything.

Comment 10 Eclipse Webmaster 2019-09-06 15:29:48 EDT

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.