Bug 286571 - Bashism in the build scripts
Summary: Bashism in the build scripts
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: LinuxTools (show other bugs)
Version: unspecified   Edit
Hardware: All Unix All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Packaging Tools Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2009-08-13 16:33 EDT by Niels Thykier CLA
Modified: 2022-01-13 14:51 EST (History)
0 users

See Also:

Attachments
Fixes bashisms in the build files. (6.89 KB, patch)
2009-08-13 16:33 EDT, Niels Thykier CLA 		overholt: iplog+
Details | Diff
patch more suitable for application in Eclipse (6.91 KB, patch)
2009-08-14 10:49 EDT, Andrew Overholt CLA 		no flags Details | Diff
mylyn/context/zip (689 bytes, application/octet-stream)
2009-08-14 10:49 EDT, Andrew Overholt CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Niels Thykier CLA 2009-08-13 16:33:12 EDT 
Created attachment 144470 [details]
Fixes bashisms in the build files.

Hi

As mentioned on the IRC channel, I found some "bashisms" in some of the build scripts, which makes them fail if you do not have "bash" providing sh. The bashisms were found by the "checkbashism" script[1].

The three "sinners" in these scripts are the use of "==" (instead of "=")[2] and "popd" + "pushd" which are both "bash builtins".

~Niels

[1] On Debian based systems, it is available in the "devscripts" package.
[2] bash has a builtin version of "[" a.k.a. test that allows the use of "==", but the non-builtin does not allow it.
Comment 1 Andrew Overholt CLA 2009-08-14 10:49:01 EDT 
Created attachment 144539 [details]
patch more suitable for application in Eclipse
Comment 2 Andrew Overholt CLA 2009-08-14 10:49:02 EDT 
Created attachment 144540 [details]
mylyn/context/zip
Comment 3 Andrew Overholt CLA 2009-08-14 10:52:04 EDT 
Thanks for the patch!  Applied in revision 22791.
Comment 4 Andrew Overholt CLA 2009-08-14 10:52:52 EDT 
Adding contributed keyword so we remember for next N&N.