Bug 28585 - Use BufferedReader with InputStreamReader
Summary: Use BufferedReader with InputStreamReader
Status: CLOSED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows 2000
: P3 normal (vote)
Target Milestone: 2.1 M5   Edit
Assignee: Tod Creasey CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2002-12-17 18:18 EST by Knut Radloff CLA
Modified: 2005-05-10 14:53 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Knut Radloff CLA 2002-12-17 18:18:35 EST 
build 20021216

InputStreamReader should usually be wrapped with a BufferedReader for a cheap 
potential performance gain. See bug 20791.
The following places do not currently do this, probably because they were 
changed after bug 20791 was fixed:
ZipFileResourceExporter.appendToManifest 
ZipFileExporter.appendToManifest 
PerspectiveRegistry.loadCustom
Comment 1 Tod Creasey CLA 2003-01-10 09:10:24 EST 
The exporter was left out because all it is doing is bulding manifest files 
which are very small - buffering is not required and it is not worth creating 
the extra objects.

I assume it is the same deal for the PerspectiveRegistry but I will reassign 
to Eduardo to confirm.
Comment 2 Eduardo Pereira CLA 2003-01-14 14:20:35 EST 
The code in PerpectiveRegistry is only used for backward compatibility but I 
added this change since it is very simple. Only wrap the InputStreamReader 
with a BufferedReader.

Moving back to Tod. In case you want to reconsider.
Comment 3 Tod Creasey CLA 2003-01-14 14:23:10 EST 
Marking as closed as all instances have been reviewed.
Comment 4 Tod Creasey CLA 2005-05-10 14:53:59 EDT 
Marking as closed.