Bug 285450 - [Dialogs] Invalid access from non-UI thread while importing Archive file
Summary: [Dialogs] Invalid access from non-UI thread while importing Archive file
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Krzysztof Daniel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 107082
Blocks:
  Show dependency tree
 
Reported: 2009-08-03 10:38 EDT by Frederic Fusier CLA
Modified: 2009-12-14 14:28 EST (History)
7 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Frederic Fusier CLA 2009-08-03 10:38:41 EDT 
Using I20090802-2000.

I was verifying bug 278047 where I had to import some sources from an Archive file. I do it once and everything works well, but I redo it and got a strange 'Import Problems' dialog: "null argument:Invalid access from non-UI thread."

Note that the 'Overwrite existing resources without warning' check-box was unchecked (the default I guess...). When I check it, there's no problem. I guess there's a problem while opening the dialog to warn the user that the resources already exists...
Comment 1 Dani Megert CLA 2009-08-03 11:17:06 EDT 
What's the stack trace?
Comment 2 Markus Keller CLA 2009-08-03 11:25:44 EDT 
Another problem caused by the initial change for bug 107082. This works fine again in HEAD, but the better fix for bug 107082 has not yet been tagged.

org.eclipse.ui.dialogs.WizardDataTransferPage.queryOverwrite(String) tries to
open the dialog and
org.eclipse.ui.internal.wizards.datatransfer.WizardFileSystemResourceImportPage1.executeImportOperation(ImportOperation) just displays an error dialog but misses to write the caught exception to the log.

You should fix the logging (and maybe also move the creation of the MessageDialog into the UI thread, similar to bug 284856).
Comment 3 Frederic Fusier CLA 2009-08-03 11:28:50 EDT 
I didn't get any exception in the error log for this dialog...
Comment 4 Susan McCourt CLA 2009-08-03 14:53:22 EDT 
It looks like platform ui was not tagged for Thursday's warm-up build, so the fix for bug 107082 has not gone into an I-build yet.  cc'ing Prakash who has been doing the I-build submissions.  I'll look into what has not been released yet...
Comment 5 Susan McCourt CLA 2009-08-03 15:10:26 EDT 
I just tagged platform UI.
This problem should be fixed in I20090803-1800.
Comment 6 Prakash Rangaraj CLA 2009-08-04 03:14:17 EDT 
(In reply to comment #4 & comment #5)

    I usually do the build submissions on Tuesday mornings (IST, thats monday evenings in Canada/USA). Now that its don, should appear in Tuesday's build
Comment 7 Susan McCourt CLA 2009-08-04 12:10:19 EDT 
I tried the scenario in I20090803-1800 and the verification dialog comes up correctly.  So I believe this is now fixed by the fix for bug 107082, but I'll move to Christopher to verify the bug.
Comment 8 John Arthorne CLA 2009-12-11 16:28:34 EST 
Is this fixed? Please mark it fixed or update the target milestone.
Comment 9 Krzysztof Daniel CLA 2009-12-14 14:28:16 EST 
This bug is fixed by 107082, and was caused by to restrictive patch for that bug, which was reverted (and replaced with one that caused no regressions).