Bug 2845 - F3 and F4 should work in the compare editor. (1GJY7MP)
Summary: F3 and F4 should work in the compare editor. (1GJY7MP)
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Compare (show other bugs)
Version: 2.0   Edit
Hardware: All All
: P2 enhancement (vote)
Target Milestone: 3.5 M5   Edit
Assignee: Tomasz Zarna CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 183632
Blocks: 169386
  Show dependency tree
 
Reported: 2001-10-10 22:44 EDT by Kevin Haaland CLA
Modified: 2009-01-07 05:58 EST (History)
3 users (show)

See Also:

Attachments
Patch v01 (9.10 KB, patch)
2008-10-14 11:30 EDT, Tomasz Zarna CLA 		no flags Details | Diff
mylyn/context/zip (117.01 KB, application/octet-stream)
2008-10-14 11:30 EDT, Tomasz Zarna CLA 		no flags Details
Patch v02 (8.55 KB, patch)
2008-10-29 06:59 EDT, Tomasz Zarna CLA 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Haaland CLA 2001-10-10 22:44:36 EDT 
Compare 2 versions of a java file.
	Select a name of a class and press F3.

	Nothing happens.

NOTES:
Comment 1 DJ Houghton CLA 2001-10-29 19:20:53 EST 
PRODUCT VERSION:
	Build 135 - Win 2000.
Comment 2 Erich Gamma CLA 2002-04-11 02:36:48 EDT 
we the new menu structure we should support to retarget these actions in the 
compare/merge viewers
Comment 3 Andre Weinand CLA 2003-01-20 07:47:49 EST 
after 2.1
Comment 4 Tomasz Zarna CLA 2008-10-08 10:29:05 EDT 
Reopening to address during 3.5
Comment 5 Tomasz Zarna CLA 2008-10-08 10:45:23 EDT 
Assigning to myself.
Comment 6 Tomasz Zarna CLA 2008-10-14 11:23:10 EDT 
Since Open Declaration and Open Type Hierarchy actions require ITextSelection from an editor this bug is blocked by bug 183632.
Comment 7 Tomasz Zarna CLA 2008-10-14 11:30:15 EDT 
Created attachment 115050 [details]
Patch v01

Rough, but working version of the patch. Patch still subject to change.
Comment 8 Tomasz Zarna CLA 2008-10-14 11:30:21 EDT 
Created attachment 115051 [details]
mylyn/context/zip
Comment 9 Tomasz Zarna CLA 2008-10-14 11:34:42 EDT 
CC'ing Dani since the fix will probably require some changes in JDT/UI.
Comment 10 Philipe Mulet CLA 2008-10-27 07:56:30 EDT 
is this still planned for M3 ? (doesn't work with I20081026-2000)
Comment 11 Tomasz Zarna CLA 2008-10-29 06:59:12 EDT 
Created attachment 116403 [details]
Patch v02

Next version of the fix that introduces a new API method in TextMergeViewer for contributing actions by merge viewers extending the TextMergeViewer. JavaMergeViewer.JavaEditorAdapter class is still a working copy, especially after what we have found in bug 250633, comment 2. F3 and F4 actions work only when comparing with a remote revision (SyncInfoCompareInput as input).
Comment 12 Tomasz Zarna CLA 2008-10-31 06:40:03 EDT 
The work will be continued during 3.5M4.
Comment 13 Tomasz Zarna CLA 2009-01-07 05:58:15 EST 
The issue has been fixed in bug 169386. The patch from comment 11 is redundant. Marking as FIXED.