Bug 284172 - [api] provide access to progress monitor to allow monitoring synchronization jobs in progress
Summary: [api] provide access to progress monitor to allow monitoring synchronization ...
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows Vista
: P2 enhancement (vote)
Target Milestone: 3.3   Edit
Assignee: Thomas Ehrnhoefer CLA
QA Contact:
URL:
Whiteboard:
Keywords: plan
Depends on:
Blocks:
 
Reported: 2009-07-21 14:53 EDT by Thomas Ehrnhoefer CLA
Modified: 2009-08-13 20:06 EDT (History)
2 users (show)

See Also:

Attachments
patch (internal) (6.78 KB, patch)
2009-07-21 17:58 EDT, Thomas Ehrnhoefer CLA 		no flags Details | Diff
mylyn/context/zip (65.00 KB, application/octet-stream)
2009-07-21 17:59 EDT, Thomas Ehrnhoefer CLA 		no flags Details
patch (api) (4.40 KB, patch)
2009-07-21 18:04 EDT, Thomas Ehrnhoefer CLA 		no flags Details | Diff
mylyn/context/zip (82.71 KB, application/octet-stream)
2009-07-21 18:04 EDT, Thomas Ehrnhoefer CLA 		no flags Details
patch (api) v2 (6.80 KB, patch)
2009-08-11 13:06 EDT, Thomas Ehrnhoefer CLA 		no flags Details | Diff
mylyn/context/zip (38.71 KB, application/octet-stream)
2009-08-11 13:06 EDT, Thomas Ehrnhoefer CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Ehrnhoefer CLA 2009-07-21 14:53:24 EDT 
Similar to bug 265565 (where we mistakenly stated in the description it is about SynchronizatioJob when it was about SubmitJob) we should provide the same means for SynchronizationJob.

from the 265565 description:
When scheduling a SynchronizeQueryJob from a UI component, such as a report, view, etc. there is no existing API available to access the progress of this synchronization which is relevant to the report, view, etc.  It would be helpful if SynchronizeQueryJob (and other sync jobs) had API to access the progress monitor of the job.  This way the view or page owner could report the progress to the user.
Comment 1 Thomas Ehrnhoefer CLA 2009-07-21 17:58:58 EDT 
Created attachment 142195 [details]
patch (internal)

This introduced the delegatingProgressMonitor to each of the internal subclasses of SynchronizationJob
Comment 2 Thomas Ehrnhoefer CLA 2009-07-21 17:59:00 EDT 
Created attachment 142196 [details]
mylyn/context/zip
Comment 3 Thomas Ehrnhoefer CLA 2009-07-21 18:04:09 EDT 
Created attachment 142197 [details]
patch (api)

This patch pulls out the field and getter of the delegatingProgressMonitor to the SynchronizationJob, making it an API change.
Note: compilation error because of API baseline (not sure if or what to put as comment, leave that to whoever applies it eventually)
Comment 4 Thomas Ehrnhoefer CLA 2009-07-21 18:04:13 EDT 
Created attachment 142198 [details]
mylyn/context/zip
Comment 5 Steffen Pingel CLA 2009-07-21 18:49:50 EDT 
I have applied the first patch with a minor modification that makes the monitor field private since it's available through the getter anyways.
Comment 6 Steffen Pingel CLA 2009-08-07 16:38:22 EDT 
Thomas, can you update your patch? It looks like it is stale.
Comment 7 Thomas Ehrnhoefer CLA 2009-08-11 13:06:54 EDT 
Created attachment 144076 [details]
patch (api) v2

whoops, guess I should have thought about that when creating the second patch :)
here is a non-stale version, thanks for catching that
Comment 8 Thomas Ehrnhoefer CLA 2009-08-11 13:06:56 EDT 
Created attachment 144077 [details]
mylyn/context/zip
Comment 9 Steffen Pingel CLA 2009-08-11 20:29:20 EDT 
Thanks Thomas! I have committed the patch.