Bug 28417 - Context menu does not have correct behaviour in Java editor
Summary: Context menu does not have correct behaviour in Java editor
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 2.1   Edit
Hardware: PC All
: P2 major (vote)
Target Milestone: 2.1 M5   Edit
Assignee: Chris McLaren CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 27232 (view as bug list)
Depends on:
Blocks:
 
Reported: 2002-12-16 14:08 EST by Felipe Heidrich CLA
Modified: 2006-11-28 09:24 EST (History)
5 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Felipe Heidrich CLA 2002-12-16 14:08:08 EST
build 20021213

Running on Motif, over the javaeditor, the menu pop-up when mouse button is
released. But on different views I have to hold the button down to get the menu.
The right behavior on Motif is to hold the button down to pop-up the menu.

For the javaeditor the SWT support (Control.setMenu) for popup menu is not been
used properly.

This will break:
Motif (different platform behavior),
GTK (menu don`t get input method menu items added),
Mac (different platform behavior).
Comment 1 Sonia Dimitrov CLA 2002-12-16 15:53:01 EST
This appears to be a duplicate of 19804.  Moving to SWT for assessment.
Comment 2 Steve Northover CLA 2002-12-17 12:02:26 EST
Sonia, 19804 is not a duplicate but could be related.  Are they trying to share 
the same menu?  I don't think so but UI needs to decide.

BTW:  This PR is at least a P2 as it violates the platform menu behavior.  It 
would not be so bad if every menu in Eclipse violated the platform but the 
menus in the tree and table widgets work properly.  This makes it a real pain 
because you need to know how the menu is popped up, depending on the widget.
Comment 3 Sonia Dimitrov CLA 2002-12-18 09:41:55 EST

*** This bug has been marked as a duplicate of 27232 ***
Comment 4 Veronika Irvine CLA 2002-12-18 13:54:33 EST
This is not a duplicate of 27232.  This problem occurs regardless of whether 
gestures are being used.

There are several implications of popping the context menu up yourself rather 
than using setMenu.

1) It does not appear and disapperar at the right time.  The correct behaviour 
depends on the platform.  e.g.

    Windows - should appear on mouse up
    Motif - should appear on mouse down and disappear on mouse up
    Mac - should appear on mouse down and stay on mouse up

Photon, QT and GTK have other variations on this.

2) For DBCS support on GTK we have added an IM (input method) item at the end 
of all context menus.  This will only happen if you call setMenu.  The Java 
editors are not DBCS enabled because they do not have this item on GTK.

3) The user should be able to make a context menu pop up from the keyboard for 
accessibility purposes.  On Windows this is done with SHIFT + F10 and other 
platforms there may be something else.  This does not work on the java editor.  
If setMenu were used, this would work.
Comment 5 Steve Northover CLA 2002-12-19 09:10:38 EST
Hey!  This is really important.  I'm surprised that this was not fixed for M4. 
I'm adding Nick in hope that something will happen.
Comment 6 Nick Edgar CLA 2002-12-19 10:06:37 EST
This was not fixed for M4, although it was supposed to have been removed.
I don't see rebuilding M4 just for this unless a product requires it.
We will remove it early in M5.

Kevin, let me know if this is critical for M4.

Comment 7 Nick Edgar CLA 2002-12-19 10:08:30 EST
*** Bug 27232 has been marked as a duplicate of this bug. ***
Comment 8 Chris McLaren CLA 2003-01-06 12:53:32 EST
gestures commented out until proper solution for them can be found. the 
newsgroup comments suggests some possible solutions, mostly involving a 
preference page that could allow the user to require that a modifier key be 
pressed, or alternate mouse button to be used, on certain platforms. (the 
opera browser doesn't seem to care much about this problem, and mozilla allows 
the user to choose a modifier key)