Bug 28402 - CompareConfiguration leaks Images
Summary: CompareConfiguration leaks Images
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Compare (show other bugs)
Version: 2.1   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 2.1 RC1   Edit
Assignee: Andre Weinand CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2002-12-16 12:13 EST by Adam Kiezun CLA
Modified: 2003-02-19 12:34 EST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Kiezun CLA 2002-12-16 12:13:32 EST 
20021216
when you do this:
1. open compare pref page
2. close

you have 1 more Image allocated and not disposed (always the same little red
conflict icon)

it's allocated here:
	at org.eclipse.swt.graphics.Image.<init>(Image.java:558)
	at org.eclipse.jface.resource.ImageDescriptor.createImage(ImageDescriptor.java:129)
	at org.eclipse.jface.resource.ImageDescriptor.createImage(ImageDescriptor.java:88)
	at org.eclipse.jface.resource.ImageDescriptor.createImage(ImageDescriptor.java:77)
	at org.eclipse.compare.CompareConfiguration.getImage(CompareConfiguration.java:162)
	at
org.eclipse.compare.contentmergeviewer.TextMergeViewer$Diff.getImage(TextMergeViewer.java:406)
	at
org.eclipse.compare.contentmergeviewer.TextMergeViewer.updateControls(TextMergeViewer.java:2512)
	at
org.eclipse.compare.contentmergeviewer.TextMergeViewer.setCurrentDiff(TextMergeViewer.java:3494)
	at
org.eclipse.compare.contentmergeviewer.TextMergeViewer.selectFirstDiff(TextMergeViewer.java:2881)
	at
org.eclipse.compare.contentmergeviewer.TextMergeViewer.access$32(TextMergeViewer.java:2867)
	at
org.eclipse.compare.contentmergeviewer.TextMergeViewer$22.run(TextMergeViewer.java:1516)
	at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java(Compiled Code))
	at
org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java(Compiled
Code))
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java(Compiled Code))
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java(Compiled Code))
	at org.eclipse.jface.window.Window.runEventLoop(Window.java(Compiled Code))
	at org.eclipse.jface.window.Window.open(Window.java:541)
	at org.eclipse.ui.internal.OpenPreferencesAction.run(OpenPreferencesAction.java:47)
Comment 1 Andre Weinand CLA 2003-02-06 11:15:30 EST 
not for 2.1
Comment 2 Andre Weinand CLA 2003-02-19 12:34:30 EST 
fix released for I20030220