Bug 2833 - [GlobalActions] File -> Save As grows unlimted depending on file name (1GJXY74)
Summary: [GlobalActions] File -> Save As grows unlimted depending on file name (1GJXY74)
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 2.0   Edit
Hardware: All Windows NT
: P3 enhancement (vote)
Target Milestone: 2.1 RC1   Edit
Assignee: Simon Arsenault CLA
QA Contact:
URL:
Whiteboard:
Keywords: investigate
Depends on:
Blocks:
 
Reported: 2001-10-10 22:44 EDT by Dani Megert CLA
Modified: 2003-02-17 13:22 EST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2001-10-10 22:44:24 EDT
The label for "File --> Save" and "File -> Save As..." menu item contain the
	file name e.g. "Save Test.java" or "Save Test.java As...". If the file name is
	very long then the file menu gets very big.

	The labels should either be "Save"/"Save As..." (at least on Windows
	this is the mostly used approach) or restrict 	the length of the
	file name.


NOTES:
Comment 1 DJ Houghton CLA 2001-10-29 19:20:03 EST
PRODUCT VERSION:
	0.135


Comment 2 Kevin Haaland CLA 2002-04-23 23:14:30 EDT
Consider for a post 2.0 change. 
Comment 3 Randy Giffen CLA 2002-08-08 16:00:03 EDT
Reopen for investigation
Comment 4 Simon Arsenault CLA 2003-02-07 12:13:56 EST
True, most apps (on my Win 2000 box) only show Save and Save As..  Need to 
confirm with usability group whether we could do this. If not, then we should 
at least limit the length of it.
Comment 5 Nick Edgar CLA 2003-02-16 21:41:14 EST
Feedback from usability group:

If the menu width is just affected by the Save and Save As filename lengths 
then I'd say go with just Save and Save As.  However, isn't it also affected by 
the MRU list?

I think the key here is to understand whether the real complaint relates to the 
legibility of the Save and Save As menu items (because of the filename "noise") 
or genuinely relates to the width of the menu itself.  If the latter then 
changes to the Save and Save As menu items aren't where the real solution lies.


Comment 6 Nick Edgar CLA 2003-02-16 21:50:05 EST
Dani, could you please clarify whether the complaint is about the width of the 
File menu when there's a long name, or is it about the legibility of the Save 
actions when including then name?

There is definitely an issue with the width of the File menu.  For very long 
file names, the file menu can get ridiculously wide since we don't enforce a 
maximum size, as we do for the MRU list.
Rather than eliminating the name entirely, we could restrict its length so that 
the total length of the menu item is 40 chars or so (as we do for the MRU list).

But if you feel that it's too cluttered to include the name in the first place, 
we can consider removing it entirely.
Comment 7 Dani Megert CLA 2003-02-17 03:39:56 EST
It's the length which is not limted and the fact that the name is used along
with Save/Save as... 

I can't speak for Linux and MAC but on Windows I don't know any application that
shows the file name along with Save/Save as... Some applications show the name
(limited to some number of characters) in their most_recent menu group.

I would check MAC and Linux and if they both show the file name in Save/Save
as... then we can limit the number of characters for the file name otherwise we
remove the name completely.
Comment 8 Simon Arsenault CLA 2003-02-17 11:56:02 EST
Talked with both Chris (for Mac) and Andrew (for Linux), and they could not 
think of or find an application that adds the file name to the Save and Save 
As.. menus. Will remove the file name from these actions for today's 
integration build.
Comment 9 Nick Edgar CLA 2003-02-17 12:17:12 EST
Julian adds:
Check with Dani whether there's an issue with even the 40 char limit (when I 
originally read the defect I assumed that the compliant would pertained to any 
string that approached even 20 chars).  I'm not sure what the correct limit 
should be,  but regardless of Dani's answer I certainly feel that any limit 
applied to the MRU list should be respected by the Save choices as well.  

Separately, should a tooltip appear over any truncated file name (I'm guessing 
this is not standard practice in the File menu; but I notice that the editor 
picker and the editor tabs do show the full file name in a tooltip if you hover 
over it).

Nick's response:
Dani has clarified that he finds the names distracting, even if not too long.
We are removing the file names from Save / Save As...
Tooltips are not supported in menus.
Comment 10 Simon Arsenault CLA 2003-02-17 13:22:43 EST
Both the Save and Save As action no longer include the file name. Will be part 
of the next integration build.