Bug 28306 - External tool builder not deleted on cancel
Summary: External tool builder not deleted on cancel
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Ant (show other bugs)
Version: 2.1   Edit
Hardware: PC Windows 2000
: P2 normal (vote)
Target Milestone: 2.1 M5   Edit
Assignee: Jared Burns CLA
QA Contact:
URL:
Whiteboard:
Keywords: ui
Depends on:
Blocks:
 
Reported: 2002-12-13 17:16 EST by Darin Swanson CLA
Modified: 2003-01-20 18:43 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Swanson CLA 2002-12-13 17:16:59 EST 
Click new on the External tools builder page
Edit the launch configuration properties
Hit OK
Hit Cancel

The external tool builder is not added to the project, but the launch 
configuration still exists on disk.
Comment 1 Jared Burns CLA 2002-12-13 22:09:35 EST 
Fixed. The property page now keeps a collection of the configurations created
while it's open and deletes those configs if the dialog is closed via Cancel.

Please verify.
Comment 2 Darin Swanson CLA 2002-12-15 19:02:00 EST 
I still have a the new .launch left out on disk for the given test case.
Comment 3 Jared Burns CLA 2002-12-15 19:56:17 EST 
I don't know what happened. It was working yesterday. Will investigate.
Comment 4 Jared Burns CLA 2002-12-15 20:07:02 EST 
The problem still happened if you renamed the config. There's a problem in the
config framework (design problem / unintuitive behavior) that we work around in
the property page with a launch configuration listener. The launch 
configuration listener now also updates the "new config" list if the config is
renamed.

Please verify.
Comment 5 Darin Swanson CLA 2002-12-15 21:01:18 EST 
Verified.
Comment 6 Darin Swanson CLA 2002-12-17 16:39:04 EST 
New test case..same problem
Comment 7 Darin Swanson CLA 2002-12-17 16:39:56 EST 
Copy an external tools builder
Hit cancel

The .launch still exists on disk.
Comment 8 Darin Swanson CLA 2003-01-16 17:48:44 EST 
Fixed in BuilderPropertyPage.
Please verify.
Comment 9 Jared Burns CLA 2003-01-20 18:43:40 EST 
Verified.