Bug 28305 - Edit properties for Launch Configuration for External tools
Summary: Edit properties for Launch Configuration for External tools
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Ant (show other bugs)
Version: 2.1   Edit
Hardware: PC Windows 2000
: P2 normal (vote)
Target Milestone: 2.1 M5   Edit
Assignee: Luc Bourlier CLA
QA Contact:
URL:
Whiteboard:
Keywords: ui
Depends on:
Blocks:
 
Reported: 2002-12-13 17:10 EST by Darin Swanson CLA
Modified: 2003-01-13 14:07 EST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Swanson CLA 2002-12-13 17:10:55 EST 
When creating a new external tool builder (Ant), the properties dialog openns 
with the OK button enabled but the launch configuration is in an error state as 
it needs a location.
Comment 1 Darin Wright CLA 2002-12-16 12:44:35 EST 
This is controlled by the tabs. There are two relevenat methods on 
ILaunchConfigurationTab:

(1)canSave() - when true, we allow saving, such that the user can save configs 
(possibly in an error state)
(2) isValid(...) - when false, an error is likely being displayed, but does not 
control the OK button/Apply button.

Re-assigning to Ant
Comment 2 Darin Swanson CLA 2003-01-10 17:07:50 EST 
Please verify the changes to ExternalToolsMainTab.
Comment 3 Luc Bourlier CLA 2003-01-13 14:07:56 EST 
Verified.
Please update the build notes (DarinS).