Bug 28275 - [JFace] PDE ColorManager leaks colors
Summary: [JFace] PDE ColorManager leaks colors
Status: RESOLVED DUPLICATE of bug 28365
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows 2000
: P2 normal (vote)
Target Milestone: 2.1 RC1   Edit
Assignee: Tod Creasey CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2002-12-13 10:48 EST by Adam Kiezun CLA
Modified: 2003-02-13 10:51 EST (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Kiezun CLA 2002-12-13 10:48:06 EST
every time you open and close the pde plugin manifest editor you get 5 new 
colors allocated from Color manager- they're always the same

{0, 0, 0}
{128, 0, 0}
{0, 128, 0}
{0, 0, 128}
{128, 128, 128}

here's the stack trace
java.lang.Error
   	at java.lang.Throwable.<init>(Unknown Source)
   	at org.eclipse.swt.graphics.Device.new_Object(Unknown Source)
   	at org.eclipse.swt.graphics.Color.<init>(Unknown Source)
   	at org.eclipse.jface.resource.JFaceColors.getColorSetting(Unknown 
Source)
   	at org.eclipse.jface.resource.JFaceColors.getHyperlinkText(Unknown 
Source)
   	at 
org.eclipse.update.ui.forms.internal.FormWidgetFactory.updateHyperlinkColors
(Unknown Source)
   	at org.eclipse.update.ui.forms.internal.FormWidgetFactory.initialize
(Unknown Source)
   	at org.eclipse.update.ui.forms.internal.FormWidgetFactory.<init>
(Unknown Source)
   	at org.eclipse.update.ui.forms.internal.FormWidgetFactory.<init>
(Unknown Source)
   	at org.eclipse.update.ui.forms.internal.AbstractForm.<init>(Unknown 
Source)
   	at org.eclipse.update.ui.forms.internal.AbstractSectionForm.<init>
(Unknown Source)
   	at org.eclipse.update.ui.forms.internal.SectionForm.<init>(Unknown 
Source)
   	at org.eclipse.update.ui.forms.internal.ScrollableSectionForm.<init>
(Unknown Source)
   	at org.eclipse.pde.internal.ui.editor.manifest.ManifestForm.<init>
(Unknown Source)
   	at 
org.eclipse.pde.internal.ui.editor.manifest.ManifestFormPage.createForm(Unknown 
Source)
   	at org.eclipse.pde.internal.ui.editor.PDEFormPage.<init>(Unknown Source)
   	at org.eclipse.pde.internal.ui.editor.PDEFormPage.<init>(Unknown Source)
   	at org.eclipse.pde.internal.ui.editor.manifest.ManifestFormPage.<init>
(Unknown Source)
   	at 
org.eclipse.pde.internal.ui.editor.manifest.ManifestEditor.createPages(Unknown 
Source)
   	at org.eclipse.pde.internal.ui.editor.PDEMultiPageEditor.<init>(Unknown 
Source)
   	at org.eclipse.pde.internal.ui.editor.manifest.ManifestEditor.<init>
(Unknown Source)
   	at java.lang.Class.newInstanceImpl(Native Method)
   	at java.lang.Class.newInstance(Unknown Source)
   	at 
org.eclipse.core.internal.plugins.PluginDescriptor.createExecutableExtension
(Unknown Source)
   	at 
org.eclipse.core.internal.plugins.PluginDescriptor.createExecutableExtension
(Unknown Source)
   	at 
org.eclipse.core.internal.plugins.ConfigurationElement.createExecutableExtension
(Unknown Source)
   	at org.eclipse.ui.internal.WorkbenchPlugin.createExtension(Unknown 
Source)
   	at org.eclipse.ui.internal.EditorManager$3.run(Unknown Source)
   	at org.eclipse.core.internal.runtime.InternalPlatform.run(Unknown 
Source)
   	at org.eclipse.core.runtime.Platform.run(Unknown Source)
   	at org.eclipse.ui.internal.EditorManager.createPart(Unknown Source)
   	at org.eclipse.ui.internal.EditorManager.openInternalEditor(Unknown 
Source)
   	at org.eclipse.ui.internal.EditorManager.openEditorFromDescriptor
(Unknown Source)
   	at org.eclipse.ui.internal.EditorManager.openEditor(Unknown Source)
   	at org.eclipse.ui.internal.WorkbenchPage.openEditor(Unknown Source)
   	at org.eclipse.ui.internal.WorkbenchPage.openEditor(Unknown Source)
   	at org.eclipse.ui.actions.OpenWithMenu.openEditor(Unknown Source)
   	at org.eclipse.ui.actions.OpenWithMenu.access$0(Unknown Source)
   	at org.eclipse.ui.actions.OpenWithMenu$2.handleEvent(Unknown Source)
   	at org.eclipse.swt.widgets.EventTable.sendEvent(Unknown Source)
   	at org.eclipse.swt.widgets.Widget.sendEvent(Unknown Source)
   	at org.eclipse.swt.widgets.Display.runDeferredEvents(Unknown Source)
   	at org.eclipse.swt.widgets.Display.readAndDispatch(Unknown Source)
   	at org.eclipse.ui.internal.Workbench.runEventLoop(Unknown Source)
   	at org.eclipse.ui.internal.Workbench.run(Unknown Source)
   	at org.eclipse.core.internal.boot.InternalBootLoader.run(Unknown Source)
   	at org.eclipse.core.boot.BootLoader.run(Unknown Source)
   	at java.lang.reflect.AccessibleObject.invokeL(Unknown Source)
   	at java.lang.reflect.Method.invoke(Unknown Source)
   	at org.eclipse.core.launcher.Main.basicRun(Unknown Source)
   	at org.eclipse.core.launcher.Main.run(Unknown Source)
   	at org.eclipse.core.launcher.Main.main(Unknown Source)
Comment 1 Dejan Glozic CLA 2002-12-13 10:55:19 EST
PDE uses JFaceColors for hyperlink colors. I beleive the contract is that 
JFaceColors owns the colors and will dispose them. I don't know why that seems 
not to be the case.

Moving to Platform UI for comments.
Comment 2 Nick Edgar CLA 2003-02-13 09:55:52 EST
There are 3 similar PRs all filed by Adam.  Are they dups?
Comment 3 Adam Kiezun CLA 2003-02-13 10:00:29 EST
they may be - i guess i filed them separate because i wasn't sure if it's pde 
or workbench
Comment 4 Tod Creasey CLA 2003-02-13 10:13:31 EST

*** This bug has been marked as a duplicate of 28385 ***
Comment 5 John Arthorne CLA 2003-02-13 10:50:54 EST
Wrong dup
Comment 6 John Arthorne CLA 2003-02-13 10:51:40 EST

*** This bug has been marked as a duplicate of 28365 ***