Bug 28213 - Adding a file to the Ant view that already exists takes way too long
Summary: Adding a file to the Ant view that already exists takes way too long
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Ant (show other bugs)
Version: 2.1   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 2.1 M4   Edit
Assignee: Darin Swanson CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance, ui
Depends on:
Blocks:
 
Reported: 2002-12-12 15:57 EST by Jared Burns CLA
Modified: 2002-12-12 17:39 EST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jared Burns CLA 2002-12-12 15:57:43 EST 
When a file is added to the Ant view, either with the "Add Build File" action
or the "Search for Build Files" action, the file is fully parsed before we
check if it is already in the view. We can short-circuit this by checking
if a project with the given file path already exists.
Comment 1 Jared Burns CLA 2002-12-12 15:59:32 EST 
Fixed as described. The best test case to see the improvement is to perform a
search that adds a bunch of build files, then perform the same search again.
Previously, the second search took just as long as the first to accomplish
nothing. Now, the second search takes almost no time.

Please verify.
Comment 2 Darin Swanson CLA 2002-12-12 17:39:13 EST 
Verified.