Bug 279902 - [Import/Export] WizardResourceImportPage.createDestinationGroup is final
Summary: [Import/Export] WizardResourceImportPage.createDestinationGroup is final
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: 4.5 M1   Edit
Assignee: Marc-André Laperle CLA
QA Contact:
URL:
Whiteboard:
Keywords: api
Depends on:
Blocks:
 
Reported: 2009-06-11 03:28 EDT by Mohamed Hussein CLA
Modified: 2014-07-24 11:00 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mohamed Hussein CLA 2009-06-11 03:28:13 EDT 
Build ID: I20090515-1143

Steps To Reproduce:
WizardResourceImportPage allows extending and overriding a lot of the functionality (source and option group) but not the destination group.

createDestinationGroup and validateDestinationGroup shouldn't be final.

More information:
Comment 1 Marc-André Laperle CLA 2014-04-04 15:48:51 EDT 
We extend WizardResourceImportPage but the destination folder is always the same in our page and it should not be modified by the user. Therefore, we would like a way to hide the destination group which contains the "Into Folder:" text widget and Browse button. A lot of methods in this class can already be overridden but not the creation of the destination group. I propose that createDestinationGroup should also be made non-final to allow extenders to create their own group or not create one at all.
Comment 2 Marc-André Laperle CLA 2014-04-04 15:56:42 EDT 
Patch:
https://git.eclipse.org/r/#/c/24477/
Comment 3 Dani Megert CLA 2014-04-07 05:58:01 EDT 
M6 was API freeze. Targeting for 4.5.