Bug 2794 - [UI] org.eclipse.ui.actionSets doc wrong (1GJNBT8)
Summary: [UI] org.eclipse.ui.actionSets doc wrong (1GJNBT8)
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 2.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Unknown User CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2001-10-10 22:43 EDT by Simon Arsenault CLA
Modified: 2005-01-18 16:45 EST (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Arsenault CLA 2001-10-10 22:43:42 EDT
In the doc for the org.eclipse.ui.actionSets extension point, it talks about the "visible"
	attribute, which according to the doc when set to true will show the action set in all
	perspectives.

	This is not the case. It does not do anything. I also could not find any code refering
	to this attribute.

NOTES:
Comment 1 Simon Arsenault CLA 2001-10-12 09:08:47 EDT
Looking more closely at this problem, I noticed the visible attribute does 
actually work but the doc should be updated to explain how. We should mention 
the action set will only get added to new opened perspectives, the perspectives 
already open when the workbench is started do not get the action set (or is 
this a bug in the code?)
Comment 2 Unknown User CLA 2001-10-12 10:43:56 EDT
The behavior is as documented.

The visible attribute is referenced within the ActionSetDescriptor class.  If 
the visible attribute is true then ActionSetDescriptor.isInitiallyVisible 
returns true and the action set is automatically added in the 
PageLayout.prefill method.
Comment 3 Simon Arsenault CLA 2001-10-12 11:27:00 EDT
I disagree ;-)

We should document the following:
1) After the plugin is install (with action set & visible = true), and the 
workbench is started, it will not show up in perspectives already opened. Only 
when new perspectives are opened

2) The action set will never appear in a custom perspective. This is really 
important because most people will customize the resource/java/etc perspective 
and save it with the same name. If this is done before the plugin with the 
visible action set is installed, opening this modified resource/java/etc 
perspective will not include the action set.
Comment 4 Unknown User CLA 2001-10-12 15:06:17 EDT
Ack.  Doc is modified to reflect.
Comment 5 DJ Houghton CLA 2001-10-29 19:17:06 EST
PRODUCT VERSION:
	0.131