Bug 2792 - Performance: computing task list summary takes lots of time (1GJJMLY)
Summary: Performance: computing task list summary takes lots of time (1GJJMLY)
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 2.0   Edit
Hardware: All Windows NT
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Nick Edgar CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2001-10-10 22:43 EDT by John Arthorne CLA
Modified: 2002-04-03 16:44 EST (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description John Arthorne CLA 2001-10-10 22:43:39 EDT
While profiling typical edit/build iterations in Eclipse, I noticed that updating the task list
status line message takes a lot of time (about 5.5% of the total time), even in the case where
there are no tasks in the task list at all! This is because it doesn't make use of the marker
deltas, but just asks Core to compute the complete set of markers for the given selection, depth, etc.
This information is already available, because the marker objects are in the table viewer.  It just has
to grab the set of markers currently visible in the table, and generate the appropriate summary message.
Even better, the task list content provider could incrementally update the summary information based on the
provided marker deltas.

NOTES:

JohnA (9/24/2001 3:20:02 PM)
	Another drawback of the current approach is that when the task list is first
	opened, fetching the markers twice causes two tree walks, that need to allocate
	lots of objects.  In an extreme case I was profiling, in a workbench with the entire
	eclipse source (11,000 files), opening the task list allocated 44,000 objects to fetch
	the markers twice.  The fourfold increase is due to the fact that it fetches two
	different kinds of markers each time (tasks and errors).
Comment 1 DJ Houghton CLA 2001-10-29 19:16:57 EST
PRODUCT VERSION:

0.131

Comment 2 Nick Edgar CLA 2002-04-03 16:44:49 EST
This is now much improved.
The counts are maintained incrementally.